Sqoop
  1. Sqoop
  2. SQOOP-437

Preparing release requires manual changes to LICENSE.txt file

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.1-incubating, 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: None
    • Labels:
      None

      Description

      Current ant targets "tar" and "srctar" are not handling file LICENSE.txt correctly and release manager have to fix them manually. It would be nice if ant would handle this stuff automatically.

      1. SQOOP-437.patch
        24 kB
        Abhijeet Gaikwad
      2. SQOOP-437.patch
        24 kB
        Abhijeet Gaikwad

        Activity

        Hide
        Abhijeet Gaikwad added a comment -

        This is the approach decided:

        1. License.txt in trunk will contain licenses for the files in lib directory under trunk.
        2. A license file for each distribution to be kept in lib/licenses/ directory
        3. srctar and tar targets to pick up their own licenses respectively from the dir mentioned in #2.

        Let me know if any suggestions.
        Thanks.

        Show
        Abhijeet Gaikwad added a comment - This is the approach decided: 1. License.txt in trunk will contain licenses for the files in lib directory under trunk. 2. A license file for each distribution to be kept in lib/licenses/ directory 3. srctar and tar targets to pick up their own licenses respectively from the dir mentioned in #2. Let me know if any suggestions. Thanks.
        Hide
        Abhijeet Gaikwad added a comment -

        Changes implemented as:
        1. src/licenses directory contains the licenses. This dir to be shipped with src tar ball.
        2. For now, we have same license file(LICENSE-BIN.txt) for all binary distributions as they ship same libraries. This is be kept under src/licenses (see #1).
        3. LICENSE.txt in trunk and that to be shipped in src tar are same.

        ant srctar - as expected
        ant tar - as expected
        ant test - success

        Show
        Abhijeet Gaikwad added a comment - Changes implemented as: 1. src/licenses directory contains the licenses. This dir to be shipped with src tar ball. 2. For now, we have same license file(LICENSE-BIN.txt) for all binary distributions as they ship same libraries. This is be kept under src/licenses (see #1). 3. LICENSE.txt in trunk and that to be shipped in src tar are same. ant srctar - as expected ant tar - as expected ant test - success
        Hide
        Abhijeet Gaikwad added a comment -
        Show
        Abhijeet Gaikwad added a comment - Review request: https://reviews.apache.org/r/6833/
        Hide
        Abhijeet Gaikwad added a comment -

        Patch changed as per review comments.

        Show
        Abhijeet Gaikwad added a comment - Patch changed as per review comments.
        Hide
        Jarek Jarcec Cecho added a comment -

        Committed revision 1378831.

        Thank you very much for your contribution Abhijeet!

        Jarcec

        Show
        Jarek Jarcec Cecho added a comment - Committed revision 1378831. Thank you very much for your contribution Abhijeet! Jarcec
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #144 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/144/)
        SQOOP-437. Preparing release requires manual changes to LICENSE.txt file.

        (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/LICENSE.txt
        • /sqoop/trunk/build.xml
        • /sqoop/trunk/src/licenses
        • /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #144 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/144/ ) SQOOP-437 . Preparing release requires manual changes to LICENSE.txt file. (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831) Result = SUCCESS jarcec : Files : /sqoop/trunk/LICENSE.txt /sqoop/trunk/build.xml /sqoop/trunk/src/licenses /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #15 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/15/)
        SQOOP-437. Preparing release requires manual changes to LICENSE.txt file.

        (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/LICENSE.txt
        • /sqoop/trunk/build.xml
        • /sqoop/trunk/src/licenses
        • /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #15 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/15/ ) SQOOP-437 . Preparing release requires manual changes to LICENSE.txt file. (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831) Result = SUCCESS jarcec : Files : /sqoop/trunk/LICENSE.txt /sqoop/trunk/build.xml /sqoop/trunk/src/licenses /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #5 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/5/)
        SQOOP-437. Preparing release requires manual changes to LICENSE.txt file.

        (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/LICENSE.txt
        • /sqoop/trunk/build.xml
        • /sqoop/trunk/src/licenses
        • /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #5 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/5/ ) SQOOP-437 . Preparing release requires manual changes to LICENSE.txt file. (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831) Result = SUCCESS jarcec : Files : /sqoop/trunk/LICENSE.txt /sqoop/trunk/build.xml /sqoop/trunk/src/licenses /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #15 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/15/)
        SQOOP-437. Preparing release requires manual changes to LICENSE.txt file.

        (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/LICENSE.txt
        • /sqoop/trunk/build.xml
        • /sqoop/trunk/src/licenses
        • /sqoop/trunk/src/licenses/LICENSE-BIN.txt
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #15 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/15/ ) SQOOP-437 . Preparing release requires manual changes to LICENSE.txt file. (Abhijeet Gaikwad via Jarek Jarcec Cecho) (Revision 1378831) Result = SUCCESS jarcec : Files : /sqoop/trunk/LICENSE.txt /sqoop/trunk/build.xml /sqoop/trunk/src/licenses /sqoop/trunk/src/licenses/LICENSE-BIN.txt

          People

          • Assignee:
            Abhijeet Gaikwad
            Reporter:
            Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development