Sqoop
  1. Sqoop
  2. SQOOP-426

Build command ant mvn-install generates Sqoop pom with incorrect group Id.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.4.1-incubating
    • Component/s: build
    • Labels:
      None

      Description

      When the ant target mvn-install is run, Sqoop artifacts are installed under ~/.m2/repository/com/cloudera/sqoop and the generated POMs have groupId set to com.cloudera.sqoop. These should be changed so that the groupId is set to org.apache.sqoop instead.

      1. SQOOP-426.patch
        1 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3507/
        -----------------------------------------------------------

        Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee.

        Summary
        -------

        I've changed ivy configuration.

        This addresses bug SQOOP-426.
        https://issues.apache.org/jira/browse/SQOOP-426

        Diffs


        /ivy/sqoop-test.xml 1231506
        /ivy/sqoop.xml 1231506

        Diff: https://reviews.apache.org/r/3507/diff

        Testing
        -------

        Action mvn-install is using correct group id.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3507/ ----------------------------------------------------------- Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee. Summary ------- I've changed ivy configuration. This addresses bug SQOOP-426 . https://issues.apache.org/jira/browse/SQOOP-426 Diffs /ivy/sqoop-test.xml 1231506 /ivy/sqoop.xml 1231506 Diff: https://reviews.apache.org/r/3507/diff Testing ------- Action mvn-install is using correct group id. Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3507/#review4402
        -----------------------------------------------------------

        Ship it!

        Thanks for the patch!

        • Bilung

        On 2012-01-14 15:18:53, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3507/

        -----------------------------------------------------------

        (Updated 2012-01-14 15:18:53)

        Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee.

        Summary

        -------

        I've changed ivy configuration.

        This addresses bug SQOOP-426.

        https://issues.apache.org/jira/browse/SQOOP-426

        Diffs

        -----

        /ivy/sqoop-test.xml 1231506

        /ivy/sqoop.xml 1231506

        Diff: https://reviews.apache.org/r/3507/diff

        Testing

        -------

        Action mvn-install is using correct group id.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3507/#review4402 ----------------------------------------------------------- Ship it! Thanks for the patch! Bilung On 2012-01-14 15:18:53, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3507/ ----------------------------------------------------------- (Updated 2012-01-14 15:18:53) Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee. Summary ------- I've changed ivy configuration. This addresses bug SQOOP-426 . https://issues.apache.org/jira/browse/SQOOP-426 Diffs ----- /ivy/sqoop-test.xml 1231506 /ivy/sqoop.xml 1231506 Diff: https://reviews.apache.org/r/3507/diff Testing ------- Action mvn-install is using correct group id. Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-01-16 19:23:28, Bilung Lee wrote:

        > Thanks for the patch!

        Thank you for the review sir. Patch is already attached to corresponding JIRA, so feel free to commit it.

        • Jarek

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3507/#review4402
        -----------------------------------------------------------

        On 2012-01-14 15:18:53, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3507/

        -----------------------------------------------------------

        (Updated 2012-01-14 15:18:53)

        Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee.

        Summary

        -------

        I've changed ivy configuration.

        This addresses bug SQOOP-426.

        https://issues.apache.org/jira/browse/SQOOP-426

        Diffs

        -----

        /ivy/sqoop-test.xml 1231506

        /ivy/sqoop.xml 1231506

        Diff: https://reviews.apache.org/r/3507/diff

        Testing

        -------

        Action mvn-install is using correct group id.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-01-16 19:23:28, Bilung Lee wrote: > Thanks for the patch! Thank you for the review sir. Patch is already attached to corresponding JIRA, so feel free to commit it. Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3507/#review4402 ----------------------------------------------------------- On 2012-01-14 15:18:53, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3507/ ----------------------------------------------------------- (Updated 2012-01-14 15:18:53) Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee. Summary ------- I've changed ivy configuration. This addresses bug SQOOP-426 . https://issues.apache.org/jira/browse/SQOOP-426 Diffs ----- /ivy/sqoop-test.xml 1231506 /ivy/sqoop.xml 1231506 Diff: https://reviews.apache.org/r/3507/diff Testing ------- Action mvn-install is using correct group id. Thanks, Jarek
        Hide
        Bilung Lee added a comment -

        Patch committed. Thanks, Jarcec!

        Show
        Bilung Lee added a comment - Patch committed. Thanks, Jarcec!
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #77 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/77/)
        SQOOP-426 Build command ant mvn-install generates Sqoop pom with incorrect group Id.

        blee : http://svn.apache.org/viewvc/?view=rev&rev=1232127
        Files :

        • /incubator/sqoop/trunk/ivy/sqoop-test.xml
        • /incubator/sqoop/trunk/ivy/sqoop.xml
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #77 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/77/ ) SQOOP-426 Build command ant mvn-install generates Sqoop pom with incorrect group Id. blee : http://svn.apache.org/viewvc/?view=rev&rev=1232127 Files : /incubator/sqoop/trunk/ivy/sqoop-test.xml /incubator/sqoop/trunk/ivy/sqoop.xml

          People

          • Assignee:
            Jarek Jarcec Cecho
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development