Sqoop
  1. Sqoop
  2. SQOOP-393

Class SqoopOptions was not properly moved

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.4.1-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Currently SqoopOptions classes in both namespaces (com.cloudera.sqoop and org.apache.sqoop) have the same implementation (looks like file copy with just few changes). We did not moved the functionality to org.apache.sqoop and set up inheritance to com.cloudera.sqoop namespace as we did with other classes.

      1. SQOOP-393.patch
        61 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2874/
        -----------------------------------------------------------

        Review request for Sqoop and Arvind Prabhakar.

        Summary
        -------

        I've moved the functionality like we did with other classes.

        This addresses bug SQOOP-393.
        https://issues.apache.org/jira/browse/SQOOP-393

        Diffs


        /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
        /src/java/org/apache/sqoop/SqoopOptions.java 1201319

        Diff: https://reviews.apache.org/r/2874/diff

        Testing
        -------

        I've passed basic tests.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2874/ ----------------------------------------------------------- Review request for Sqoop and Arvind Prabhakar. Summary ------- I've moved the functionality like we did with other classes. This addresses bug SQOOP-393 . https://issues.apache.org/jira/browse/SQOOP-393 Diffs /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319 /src/java/org/apache/sqoop/SqoopOptions.java 1201319 Diff: https://reviews.apache.org/r/2874/diff Testing ------- I've passed basic tests. Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2874/
        -----------------------------------------------------------

        (Updated 2011-11-17 18:47:44.428152)

        Review request for Sqoop and Arvind Prabhakar.

        Changes
        -------

        Fixed checkstyle violations.

        Summary
        -------

        I've moved the functionality like we did with other classes.

        This addresses bug SQOOP-393.
        https://issues.apache.org/jira/browse/SQOOP-393

        Diffs (updated)


        /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
        /src/java/org/apache/sqoop/SqoopOptions.java 1201319

        Diff: https://reviews.apache.org/r/2874/diff

        Testing
        -------

        I've passed basic tests.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2874/ ----------------------------------------------------------- (Updated 2011-11-17 18:47:44.428152) Review request for Sqoop and Arvind Prabhakar. Changes ------- Fixed checkstyle violations. Summary ------- I've moved the functionality like we did with other classes. This addresses bug SQOOP-393 . https://issues.apache.org/jira/browse/SQOOP-393 Diffs (updated) /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319 /src/java/org/apache/sqoop/SqoopOptions.java 1201319 Diff: https://reviews.apache.org/r/2874/diff Testing ------- I've passed basic tests. Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2874/#review3334
        -----------------------------------------------------------

        Ship it!

        +1

        Thanks for the patch Jarcec. Please attach the patch to the JIRA for commit.

        • Arvind

        On 2011-11-17 18:47:44, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2874/

        -----------------------------------------------------------

        (Updated 2011-11-17 18:47:44)

        Review request for Sqoop and Arvind Prabhakar.

        Summary

        -------

        I've moved the functionality like we did with other classes.

        This addresses bug SQOOP-393.

        https://issues.apache.org/jira/browse/SQOOP-393

        Diffs

        -----

        /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319

        /src/java/org/apache/sqoop/SqoopOptions.java 1201319

        Diff: https://reviews.apache.org/r/2874/diff

        Testing

        -------

        I've passed basic tests.

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2874/#review3334 ----------------------------------------------------------- Ship it! +1 Thanks for the patch Jarcec. Please attach the patch to the JIRA for commit. Arvind On 2011-11-17 18:47:44, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2874/ ----------------------------------------------------------- (Updated 2011-11-17 18:47:44) Review request for Sqoop and Arvind Prabhakar. Summary ------- I've moved the functionality like we did with other classes. This addresses bug SQOOP-393 . https://issues.apache.org/jira/browse/SQOOP-393 Diffs ----- /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319 /src/java/org/apache/sqoop/SqoopOptions.java 1201319 Diff: https://reviews.apache.org/r/2874/diff Testing ------- I've passed basic tests. Thanks, Jarek
        Hide
        Jarek Jarcec Cecho added a comment -

        I've moved the SqoopOptions class functionality as we did with other classes.

        Show
        Jarek Jarcec Cecho added a comment - I've moved the SqoopOptions class functionality as we did with other classes.
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Jarcec.

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Jarcec.
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #63 (See https://builds.apache.org/job/Sqoop-jdk-1.6/63/)
        SQOOP-393. Class SqoopOptions was not properly moved.

        (Jarek Jarcec via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1203759
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/SqoopOptions.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/SqoopOptions.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #63 (See https://builds.apache.org/job/Sqoop-jdk-1.6/63/ ) SQOOP-393 . Class SqoopOptions was not properly moved. (Jarek Jarcec via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1203759 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/SqoopOptions.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/SqoopOptions.java

          People

          • Assignee:
            Jarek Jarcec Cecho
            Reporter:
            Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development