Sqoop
  1. Sqoop
  2. SQOOP-392

Build using maven is broklend due to missing class generated by script write-version-info.sh

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.4.1-incubating
    • Component/s: build
    • Labels:
      None

      Description

      Checkout of current trunk or 1.4.0 branch can't be compiled with maven because of following error message:

      [ERROR] /home/jarcec/projects/apache/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java:[36,41] cannot find symbol
      symbol : class SqoopVersion
      location: package org.apache.sqoop

      This class is generated by script write-version-info.sh that is executed by ant, but not by maven.

      1. SQOOP-392-1.patch
        4 kB
        Arvind Prabhakar

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2920/
        -----------------------------------------------------------

        Review request for Sqoop and Jarek Cecho.

        Summary
        -------

        The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.

        This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.

        This addresses bug SQOOP-392.
        https://issues.apache.org/jira/browse/SQOOP-392

        Diffs


        /pom.xml 1205214
        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214

        Diff: https://reviews.apache.org/r/2920/diff

        Testing
        -------

        The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.

        Also tested the build via ant - and all tests passed successfully.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2920/ ----------------------------------------------------------- Review request for Sqoop and Jarek Cecho. Summary ------- The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass. This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem. This addresses bug SQOOP-392 . https://issues.apache.org/jira/browse/SQOOP-392 Diffs /pom.xml 1205214 /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 Diff: https://reviews.apache.org/r/2920/diff Testing ------- The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA. Also tested the build via ant - and all tests passed successfully. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2920/#review3470
        -----------------------------------------------------------

        Ship it!

        Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.

        Jarcec

        • Jarek

        On 2011-11-23 03:29:36, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2920/

        -----------------------------------------------------------

        (Updated 2011-11-23 03:29:36)

        Review request for Sqoop and Jarek Cecho.

        Summary

        -------

        The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.

        This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.

        This addresses bug SQOOP-392.

        https://issues.apache.org/jira/browse/SQOOP-392

        Diffs

        -----

        /pom.xml 1205214

        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214

        Diff: https://reviews.apache.org/r/2920/diff

        Testing

        -------

        The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.

        Also tested the build via ant - and all tests passed successfully.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2920/#review3470 ----------------------------------------------------------- Ship it! Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit. Jarcec Jarek On 2011-11-23 03:29:36, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2920/ ----------------------------------------------------------- (Updated 2011-11-23 03:29:36) Review request for Sqoop and Jarek Cecho. Summary ------- The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass. This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem. This addresses bug SQOOP-392 . https://issues.apache.org/jira/browse/SQOOP-392 Diffs ----- /pom.xml 1205214 /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 Diff: https://reviews.apache.org/r/2920/diff Testing ------- The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA. Also tested the build via ant - and all tests passed successfully. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-11-23 07:07:13, Jarek Cecho wrote:

        > Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit.

        >

        > Jarcec

        Thanks for the review Jarcec. The patch is attached to the JIRA.

        • Arvind

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2920/#review3470
        -----------------------------------------------------------

        On 2011-11-23 03:29:36, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2920/

        -----------------------------------------------------------

        (Updated 2011-11-23 03:29:36)

        Review request for Sqoop and Jarek Cecho.

        Summary

        -------

        The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass.

        This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem.

        This addresses bug SQOOP-392.

        https://issues.apache.org/jira/browse/SQOOP-392

        Diffs

        -----

        /pom.xml 1205214

        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214

        Diff: https://reviews.apache.org/r/2920/diff

        Testing

        -------

        The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA.

        Also tested the build via ant - and all tests passed successfully.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-11-23 07:07:13, Jarek Cecho wrote: > Thank you Arvind, changes looks good. Please attach your patch to JIRA and I'll try to do my first commit. > > Jarcec Thanks for the review Jarcec. The patch is attached to the JIRA. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2920/#review3470 ----------------------------------------------------------- On 2011-11-23 03:29:36, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2920/ ----------------------------------------------------------- (Updated 2011-11-23 03:29:36) Review request for Sqoop and Jarek Cecho. Summary ------- The maven build is broken due to the missing SqoopVersion.java file(s) that are generated via the ant build. Also, on my development machine running Ubuntu 11.04 I am seeing a failure in the maven compiler plugin caused by the cross-referencing of namespace for DBOutputFormat class and its subclass. This change introduces the maven-antrun-plugin to generate the SqoopVersion.java files, uses the org.codehaus.mojo:build-helper-maven-plugin to add the generated source directory to the compiler source path and also fixes the DBOutputFormat to avoid the maven compiler crash problem. This addresses bug SQOOP-392 . https://issues.apache.org/jira/browse/SQOOP-392 Diffs ----- /pom.xml 1205214 /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1205214 Diff: https://reviews.apache.org/r/2920/diff Testing ------- The maven build invokes rat plugin which fails due to missing or incorrect license headers. This can be locally avoided by passing in the property such as -Drat.numUnapprovedLicenses=1000. This issue should be addressed by a different JIRA. Also tested the build via ant - and all tests passed successfully. Thanks, Arvind
        Hide
        Jarek Jarcec Cecho added a comment -

        Patch has been committed. Thank you very much Arvind!

        Show
        Jarek Jarcec Cecho added a comment - Patch has been committed. Thank you very much Arvind!
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #65 (See https://builds.apache.org/job/Sqoop-jdk-1.6/65/)
        SQOOP-392. Build using maven is broken due to missing class generated by script write-version-info.sh

        (Arvind Prabhakar via Jarek Jarcec Cecho)

        jarcec : http://svn.apache.org/viewvc/?view=rev&rev=1206698
        Files :

        • /incubator/sqoop/trunk/pom.xml
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #65 (See https://builds.apache.org/job/Sqoop-jdk-1.6/65/ ) SQOOP-392 . Build using maven is broken due to missing class generated by script write-version-info.sh (Arvind Prabhakar via Jarek Jarcec Cecho) jarcec : http://svn.apache.org/viewvc/?view=rev&rev=1206698 Files : /incubator/sqoop/trunk/pom.xml /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java

          People

          • Assignee:
            Arvind Prabhakar
            Reporter:
            Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development