Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      • Add license header to each script used for Hive import testing.
      • Revise the comparion script to ignore the license header.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2716/
        -----------------------------------------------------------

        Review request for Sqoop and Arvind Prabhakar.

        Summary
        -------

        Patch for SQOOP-388.

        This addresses bug SQOOP-388.
        https://issues.apache.org/jira/browse/SQOOP-388

        Diffs


        ./testdata/hive/bin/hive 1187139
        ./testdata/hive/scripts/createOnlyImport.q 1196702
        ./testdata/hive/scripts/createOverwriteImport.q 1196702
        ./testdata/hive/scripts/customDelimImport.q 1196702
        ./testdata/hive/scripts/dateImport.q 1196701
        ./testdata/hive/scripts/failingImport.q 1196702
        ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702
        ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702
        ./testdata/hive/scripts/normalImport.q 1196702
        ./testdata/hive/scripts/numericImport.q 1196702
        ./testdata/hive/scripts/partitionImport.q 1196702

        Diff: https://reviews.apache.org/r/2716/diff

        Testing
        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2716/ ----------------------------------------------------------- Review request for Sqoop and Arvind Prabhakar. Summary ------- Patch for SQOOP-388 . This addresses bug SQOOP-388 . https://issues.apache.org/jira/browse/SQOOP-388 Diffs ./testdata/hive/bin/hive 1187139 ./testdata/hive/scripts/createOnlyImport.q 1196702 ./testdata/hive/scripts/createOverwriteImport.q 1196702 ./testdata/hive/scripts/customDelimImport.q 1196702 ./testdata/hive/scripts/dateImport.q 1196701 ./testdata/hive/scripts/failingImport.q 1196702 ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702 ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702 ./testdata/hive/scripts/normalImport.q 1196702 ./testdata/hive/scripts/numericImport.q 1196702 ./testdata/hive/scripts/partitionImport.q 1196702 Diff: https://reviews.apache.org/r/2716/diff Testing ------- Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2716/#review3041
        -----------------------------------------------------------

        Ship it!

        +1

        Changes look good. Please attach the patch to JIRA.

        • Arvind

        On 2011-11-03 19:49:56, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2716/

        -----------------------------------------------------------

        (Updated 2011-11-03 19:49:56)

        Review request for Sqoop and Arvind Prabhakar.

        Summary

        -------

        Patch for SQOOP-388.

        This addresses bug SQOOP-388.

        https://issues.apache.org/jira/browse/SQOOP-388

        Diffs

        -----

        ./testdata/hive/bin/hive 1187139

        ./testdata/hive/scripts/createOnlyImport.q 1196702

        ./testdata/hive/scripts/createOverwriteImport.q 1196702

        ./testdata/hive/scripts/customDelimImport.q 1196702

        ./testdata/hive/scripts/dateImport.q 1196701

        ./testdata/hive/scripts/failingImport.q 1196702

        ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702

        ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702

        ./testdata/hive/scripts/normalImport.q 1196702

        ./testdata/hive/scripts/numericImport.q 1196702

        ./testdata/hive/scripts/partitionImport.q 1196702

        Diff: https://reviews.apache.org/r/2716/diff

        Testing

        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2716/#review3041 ----------------------------------------------------------- Ship it! +1 Changes look good. Please attach the patch to JIRA. Arvind On 2011-11-03 19:49:56, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2716/ ----------------------------------------------------------- (Updated 2011-11-03 19:49:56) Review request for Sqoop and Arvind Prabhakar. Summary ------- Patch for SQOOP-388 . This addresses bug SQOOP-388 . https://issues.apache.org/jira/browse/SQOOP-388 Diffs ----- ./testdata/hive/bin/hive 1187139 ./testdata/hive/scripts/createOnlyImport.q 1196702 ./testdata/hive/scripts/createOverwriteImport.q 1196702 ./testdata/hive/scripts/customDelimImport.q 1196702 ./testdata/hive/scripts/dateImport.q 1196701 ./testdata/hive/scripts/failingImport.q 1196702 ./testdata/hive/scripts/fieldWithNewlineImport.q 1196702 ./testdata/hive/scripts/fieldWithNewlineReplacementImport.q 1196702 ./testdata/hive/scripts/normalImport.q 1196702 ./testdata/hive/scripts/numericImport.q 1196702 ./testdata/hive/scripts/partitionImport.q 1196702 Diff: https://reviews.apache.org/r/2716/diff Testing ------- Thanks, Bilung
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Bilung!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Bilung!
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #57 (See https://builds.apache.org/job/Sqoop-jdk-1.6/57/)
        SQOOP-388. Add license header to Hive testdata.

        (Bilung Lee via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1197346
        Files :

        • /incubator/sqoop/trunk/testdata/hive/bin/hive
        • /incubator/sqoop/trunk/testdata/hive/scripts/createOnlyImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/createOverwriteImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/customDelimImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/dateImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/failingImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/fieldWithNewlineImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/fieldWithNewlineReplacementImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/normalImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/numericImport.q
        • /incubator/sqoop/trunk/testdata/hive/scripts/partitionImport.q
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #57 (See https://builds.apache.org/job/Sqoop-jdk-1.6/57/ ) SQOOP-388 . Add license header to Hive testdata. (Bilung Lee via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1197346 Files : /incubator/sqoop/trunk/testdata/hive/bin/hive /incubator/sqoop/trunk/testdata/hive/scripts/createOnlyImport.q /incubator/sqoop/trunk/testdata/hive/scripts/createOverwriteImport.q /incubator/sqoop/trunk/testdata/hive/scripts/customDelimImport.q /incubator/sqoop/trunk/testdata/hive/scripts/dateImport.q /incubator/sqoop/trunk/testdata/hive/scripts/failingImport.q /incubator/sqoop/trunk/testdata/hive/scripts/fieldWithNewlineImport.q /incubator/sqoop/trunk/testdata/hive/scripts/fieldWithNewlineReplacementImport.q /incubator/sqoop/trunk/testdata/hive/scripts/normalImport.q /incubator/sqoop/trunk/testdata/hive/scripts/numericImport.q /incubator/sqoop/trunk/testdata/hive/scripts/partitionImport.q

          People

          • Assignee:
            Bilung Lee
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development