Sqoop
  1. Sqoop
  2. SQOOP-369 Sqoop 1.4.0 release preparation
  3. SQOOP-375

Migrate metastore and metastore.hsqldb packages to new name space

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Refer to SQOOP-371 for details.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2612/
        -----------------------------------------------------------

        Review request for Sqoop and Bilung Lee.

        Summary
        -------

        I've migrated the metastore packages.

        This addresses bug SQOOP-375.
        https://issues.apache.org/jira/browse/SQOOP-375

        Diffs


        /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770
        /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770
        /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2612/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- I've migrated the metastore packages. This addresses bug SQOOP-375 . https://issues.apache.org/jira/browse/SQOOP-375 Diffs /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770 /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/2612/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2612/#review2950
        -----------------------------------------------------------

        Thanks for your contribution, Jarcec! Some comments below.

        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java
        <https://reviews.apache.org/r/2612/#comment6594>

        Remove trailing space.

        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java
        <https://reviews.apache.org/r/2612/#comment6605>

        Remove the non-static method in subclass.

        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        <https://reviews.apache.org/r/2612/#comment6596>

        Remove trailing space.

        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        <https://reviews.apache.org/r/2612/#comment6604>

        Should inherit from "org.apache.sqoop.metastore.hsqldb.AutoHsqldbStorage".

        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        <https://reviews.apache.org/r/2612/#comment6603>

        Remove this constant, which is private and is not needed.

        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java
        <https://reviews.apache.org/r/2612/#comment6606>

        Change to "com.cloudera.sqoop.metastore.JobStorage". I.e. should inherit from this for backward compatibility.

        • Bilung

        On 2011-10-29 14:04:59, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2612/

        -----------------------------------------------------------

        (Updated 2011-10-29 14:04:59)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        I've migrated the metastore packages.

        This addresses bug SQOOP-375.

        https://issues.apache.org/jira/browse/SQOOP-375

        Diffs

        -----

        /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770

        /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770

        /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2612/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/#review2950 ----------------------------------------------------------- Thanks for your contribution, Jarcec! Some comments below. /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java < https://reviews.apache.org/r/2612/#comment6594 > Remove trailing space. /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java < https://reviews.apache.org/r/2612/#comment6605 > Remove the non-static method in subclass. /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java < https://reviews.apache.org/r/2612/#comment6596 > Remove trailing space. /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java < https://reviews.apache.org/r/2612/#comment6604 > Should inherit from "org.apache.sqoop.metastore.hsqldb.AutoHsqldbStorage". /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java < https://reviews.apache.org/r/2612/#comment6603 > Remove this constant, which is private and is not needed. /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java < https://reviews.apache.org/r/2612/#comment6606 > Change to "com.cloudera.sqoop.metastore.JobStorage". I.e. should inherit from this for backward compatibility. Bilung On 2011-10-29 14:04:59, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/ ----------------------------------------------------------- (Updated 2011-10-29 14:04:59) Review request for Sqoop and Bilung Lee. Summary ------- I've migrated the metastore packages. This addresses bug SQOOP-375 . https://issues.apache.org/jira/browse/SQOOP-375 Diffs ----- /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770 /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/2612/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2612/
        -----------------------------------------------------------

        (Updated 2011-10-31 17:37:06.405514)

        Review request for Sqoop and Bilung Lee.

        Changes
        -------

        Hi Bilung, I'm sorry for having so many bugs. I've tried to correct them.

        Summary
        -------

        I've migrated the metastore packages.

        This addresses bug SQOOP-375.
        https://issues.apache.org/jira/browse/SQOOP-375

        Diffs (updated)


        /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770
        /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770
        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770
        /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION
        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2612/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/ ----------------------------------------------------------- (Updated 2011-10-31 17:37:06.405514) Review request for Sqoop and Bilung Lee. Changes ------- Hi Bilung, I'm sorry for having so many bugs. I've tried to correct them. Summary ------- I've migrated the metastore packages. This addresses bug SQOOP-375 . https://issues.apache.org/jira/browse/SQOOP-375 Diffs (updated) /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770 /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/2612/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2612/#review2979
        -----------------------------------------------------------

        Ship it!

        Thanks for your fast turnaround!

        • Bilung

        On 2011-10-31 17:37:06, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2612/

        -----------------------------------------------------------

        (Updated 2011-10-31 17:37:06)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        I've migrated the metastore packages.

        This addresses bug SQOOP-375.

        https://issues.apache.org/jira/browse/SQOOP-375

        Diffs

        -----

        /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770

        /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770

        /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770

        /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION

        /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2612/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/#review2979 ----------------------------------------------------------- Ship it! Thanks for your fast turnaround! Bilung On 2011-10-31 17:37:06, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/ ----------------------------------------------------------- (Updated 2011-10-31 17:37:06) Review request for Sqoop and Bilung Lee. Summary ------- I've migrated the metastore packages. This addresses bug SQOOP-375 . https://issues.apache.org/jira/browse/SQOOP-375 Diffs ----- /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770 /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770 /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java PRE-CREATION /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java PRE-CREATION Diff: https://reviews.apache.org/r/2612/diff Testing ------- Thanks, Jarek
        Hide
        Bilung Lee added a comment -

        Thanks Jarcec! Patch is in.

        Show
        Bilung Lee added a comment - Thanks Jarcec! Patch is in.
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/)
        SQOOP-375: Migrate metastore and metastore.hsqldb packages to new name space

        blee : http://svn.apache.org/viewvc/?view=rev&rev=1195857
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobData.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobStorage.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobData.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobStorage.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobStorageFactory.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/ ) SQOOP-375 : Migrate metastore and metastore.hsqldb packages to new name space blee : http://svn.apache.org/viewvc/?view=rev&rev=1195857 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobData.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobStorage.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobData.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobStorage.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/JobStorageFactory.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java

          People

          • Assignee:
            Jarek Jarcec Cecho
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development