Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1-incubating
    • Component/s: None
    • Labels:
      None
    1. 0001-SQOOP-306.-move-documentation-generation-to-the-mave.patch
      3 kB
      Alex Newman
    2. SQOOP-356-v2.patch
      2 kB
      Alex Newman
    3. SQOOP-356-v3.patch
      2 kB
      Alex Newman

      Activity

      Hide
      Alex Newman added a comment -

      This now builds the asciidocs when we mvn package

      Show
      Alex Newman added a comment - This now builds the asciidocs when we mvn package
      Hide
      Arvind Prabhakar added a comment -

      Changes look good Alex. One thing though - the current docs also includes API documentation which is not generated by make. For that, we need to modify the pom.xml to bind javadoc:javadoc to the package phase with the output directory specifically set to target/docs/api.

      Show
      Arvind Prabhakar added a comment - Changes look good Alex. One thing though - the current docs also includes API documentation which is not generated by make. For that, we need to modify the pom.xml to bind javadoc:javadoc to the package phase with the output directory specifically set to target/docs/api.
      Hide
      Alex Newman added a comment -

      I attached the sources and javadocs as jars as well. It's mostly for my own selfishness, but I'd prefer a jar of the javadocs anyday.

      Show
      Alex Newman added a comment - I attached the sources and javadocs as jars as well. It's mostly for my own selfishness, but I'd prefer a jar of the javadocs anyday.
      Hide
      Arvind Prabhakar added a comment -

      There is some regression from the previous patch. When I do mvn package -DskipTests, the javadocs do get generated in the right place but the rest of the documentation does not. I think you need to bind the make exec invocation to the package phase.

      Show
      Arvind Prabhakar added a comment - There is some regression from the previous patch. When I do mvn package -DskipTests, the javadocs do get generated in the right place but the rest of the documentation does not. I think you need to bind the make exec invocation to the package phase.
      Hide
      Alex Newman added a comment -

      I double checked to make sure both the api and the handbook were created. I then clicked around. We still aren't building the release notes in an automated fashion. Is that purposeful? Also notice I used a more compact notation for passing variables to make.

      Show
      Alex Newman added a comment - I double checked to make sure both the api and the handbook were created. I then clicked around. We still aren't building the release notes in an automated fashion. Is that purposeful? Also notice I used a more compact notation for passing variables to make.
      Hide
      Arvind Prabhakar added a comment -

      +1

      Patch looks good Alex! The release notes is already an issue so that can be fixed on a separate JIRA.

      Show
      Arvind Prabhakar added a comment - +1 Patch looks good Alex! The release notes is already an issue so that can be fixed on a separate JIRA.
      Hide
      Arvind Prabhakar added a comment -

      Patch committed. Thanks Alex!

      Show
      Arvind Prabhakar added a comment - Patch committed. Thanks Alex!
      Hide
      Hudson added a comment -

      Integrated in Sqoop-jdk-1.6 #42 (See https://builds.apache.org/job/Sqoop-jdk-1.6/42/)
      SQOOP-356. Move documentation generation to maven build.

      (Alex Newman via Arvind Prabhakar)

      arvind : http://svn.apache.org/viewvc/?view=rev&rev=1186918
      Files :

      • /incubator/sqoop/trunk/pom.xml
      Show
      Hudson added a comment - Integrated in Sqoop-jdk-1.6 #42 (See https://builds.apache.org/job/Sqoop-jdk-1.6/42/ ) SQOOP-356 . Move documentation generation to maven build. (Alex Newman via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1186918 Files : /incubator/sqoop/trunk/pom.xml

        People

        • Assignee:
          Alex Newman
          Reporter:
          Olivier Lamy (*$^¨%`£)
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development