Sqoop
  1. Sqoop
  2. SQOOP-346

Sqoop needs to be using java version 1.6 for its source

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/1990/
      -----------------------------------------------------------

      Review request for Sqoop.

      Summary
      -------

      We currently define these variables and then never use them. Also because of our use of override we need to tie ourselves to java 6.0 or greater.

      This addresses bug SQOOP-346.
      https://issues.apache.org/jira/browse/SQOOP-346

      Diffs


      pom.xml fd4e7cb

      Diff: https://reviews.apache.org/r/1990/diff

      Testing
      -------

      Ran ant package and a mvn install. It also got rid of some errors on my ide

      Thanks,

      Alex

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1990/ ----------------------------------------------------------- Review request for Sqoop. Summary ------- We currently define these variables and then never use them. Also because of our use of override we need to tie ourselves to java 6.0 or greater. This addresses bug SQOOP-346 . https://issues.apache.org/jira/browse/SQOOP-346 Diffs pom.xml fd4e7cb Diff: https://reviews.apache.org/r/1990/diff Testing ------- Ran ant package and a mvn install. It also got rid of some errors on my ide Thanks, Alex
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/1990/#review2072
      -----------------------------------------------------------

      Ship it!

      +1

      • Arvind

      On 2011-09-20 23:17:32, Alex Newman wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/1990/

      -----------------------------------------------------------

      (Updated 2011-09-20 23:17:32)

      Review request for Sqoop.

      Summary

      -------

      We currently define these variables and then never use them. Also because of our use of override we need to tie ourselves to java 6.0 or greater.

      This addresses bug SQOOP-346.

      https://issues.apache.org/jira/browse/SQOOP-346

      Diffs

      -----

      pom.xml fd4e7cb

      Diff: https://reviews.apache.org/r/1990/diff

      Testing

      -------

      Ran ant package and a mvn install. It also got rid of some errors on my ide

      Thanks,

      Alex

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1990/#review2072 ----------------------------------------------------------- Ship it! +1 Arvind On 2011-09-20 23:17:32, Alex Newman wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1990/ ----------------------------------------------------------- (Updated 2011-09-20 23:17:32) Review request for Sqoop. Summary ------- We currently define these variables and then never use them. Also because of our use of override we need to tie ourselves to java 6.0 or greater. This addresses bug SQOOP-346 . https://issues.apache.org/jira/browse/SQOOP-346 Diffs ----- pom.xml fd4e7cb Diff: https://reviews.apache.org/r/1990/diff Testing ------- Ran ant package and a mvn install. It also got rid of some errors on my ide Thanks, Alex
      Hide
      Arvind Prabhakar added a comment -

      Patch committed. Thanks Alex!

      Show
      Arvind Prabhakar added a comment - Patch committed. Thanks Alex!
      Hide
      Hudson added a comment -

      Integrated in Sqoop-jdk-1.6 #29 (See https://builds.apache.org/job/Sqoop-jdk-1.6/29/)
      SQOOP-346. Use Java version 1.6 for source and target.

      (Alex Newman via Arvind Prabhakar)

      arvind : http://svn.apache.org/viewvc/?view=rev&rev=1176123
      Files :

      • /incubator/sqoop/trunk/pom.xml
      Show
      Hudson added a comment - Integrated in Sqoop-jdk-1.6 #29 (See https://builds.apache.org/job/Sqoop-jdk-1.6/29/ ) SQOOP-346 . Use Java version 1.6 for source and target. (Alex Newman via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1176123 Files : /incubator/sqoop/trunk/pom.xml

        People

        • Assignee:
          Alex Newman
          Reporter:
          Alex Newman
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development