Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-339

Use of non-portable mknod utility causes build problems on Mac OS X

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Duplicating this issue from SQOOP-175, which is in the cloudera JIRA

      From SQOOP-175's description by Ken Krugler :

      On Mac OS X 10.6.3, the TestNamedFifo.testNamedFifo() test fails. The error is caused by the Shell.execCommand() use of mknod, since (at least on my Mac) mknod doesn't know about the --mode=xxx parameter or the -p parameters.

      Based on http://stackoverflow.com/questions/4546356/is-mknod-portable-if-not-what-is-the-alternative, I switched the code to use mkfifo and it now passes all tests.

      The change to NamedFifo.create() is trivial:

      Shell.execCommand("mkfifo", "-m", "0" + modeStr, filename);

      But I have no way of trying this out on other OSes, so it might create a different compatibility issue.

        Attachments

        1. SQOOP-339-6.patch
          2 kB
          Joey Echeverria
        2. SQOOP-339-5.patch
          2 kB
          Joey Echeverria
        3. SQOOP-339-4.patch
          2 kB
          Joey Echeverria
        4. SQOOP-339-3.patch
          2 kB
          Joey Echeverria
        5. SQOOP-339-2.patch
          1 kB
          Joey Echeverria
        6. SQOOP-339-1.patch
          1.0 kB
          Joey Echeverria

          Activity

            People

            • Assignee:
              fwiffo Joey Echeverria
              Reporter:
              jboyd963 Joseph Boyd
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: