Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      By default, since log4j is explicitly excluded in the pom.xml. Intellij wont be able to build sqoop in the places that org.apache.log4j is referenced. There are two options as I see it:

      Option 1: Remove the exclusion and be tied to the implicit version that the rest of the apache projects use
      Option 2: Explicitly import it

      Amusingly, I think the first will cause less compatibility issues, although it is slightly more magical.

        Activity

        Hide
        Alex Newman added a comment -

        Here's Option 1

        Show
        Alex Newman added a comment - Here's Option 1
        Hide
        Arvind Prabhakar added a comment -

        Thanks for the patch Alex. The log4j exclusion on HBase is required since it was forcing some dependencies that were not available in the central repository. So it will be preferable to go with option 2, and to ensure compatibility, set its scope to provided.

        Show
        Arvind Prabhakar added a comment - Thanks for the patch Alex. The log4j exclusion on HBase is required since it was forcing some dependencies that were not available in the central repository. So it will be preferable to go with option 2, and to ensure compatibility, set its scope to provided.
        Hide
        Alex Newman added a comment -

        Arvind sounds good. Do we have an opinion on the version? I added the newest one.

        Show
        Alex Newman added a comment - Arvind sounds good. Do we have an opinion on the version? I added the newest one.
        Hide
        Arvind Prabhakar added a comment -

        Sorry about the delay on this Alex. The version of log4j specified in ivy/libraries.properties is 1.2.15, however that version will not work for Maven build since it pulls in many unnecessary dependencies. Can you please update the patch so that the version in ivy/libraries.properties is also 1.2.16?

        Also, a nit: please generate patch using the --no-prefix option to ensure that it can be applied directly.

        Show
        Arvind Prabhakar added a comment - Sorry about the delay on this Alex. The version of log4j specified in ivy/libraries.properties is 1.2.15, however that version will not work for Maven build since it pulls in many unnecessary dependencies. Can you please update the patch so that the version in ivy/libraries.properties is also 1.2.16? Also, a nit: please generate patch using the --no-prefix option to ensure that it can be applied directly.
        Hide
        Alex Newman added a comment -

        Generated with no-prefix also, tested with ant package

        Show
        Alex Newman added a comment - Generated with no-prefix also, tested with ant package
        Hide
        Arvind Prabhakar added a comment -

        +1 Patch looks good.

        Show
        Arvind Prabhakar added a comment - +1 Patch looks good.
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #24 (See https://builds.apache.org/job/Sqoop-jdk-1.6/24/)
        SQOOP-325. Sqoop doesn't build on itelliJ.

        (Alex Newman via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1171193
        Files :

        • /incubator/sqoop/trunk/ivy/libraries.properties
        • /incubator/sqoop/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #24 (See https://builds.apache.org/job/Sqoop-jdk-1.6/24/ ) SQOOP-325 . Sqoop doesn't build on itelliJ. (Alex Newman via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1171193 Files : /incubator/sqoop/trunk/ivy/libraries.properties /incubator/sqoop/trunk/pom.xml
        Hide
        Alex Newman added a comment -

        Looks resolved to me.

        Show
        Alex Newman added a comment - Looks resolved to me.
        Hide
        Arvind Prabhakar added a comment -

        Closing the issue. Thanks Alex!

        Show
        Arvind Prabhakar added a comment - Closing the issue. Thanks Alex!

          People

          • Assignee:
            Alex Newman
            Reporter:
            Alex Newman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development