[SQOOP-3233] SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.6
• Fix Version/s: 1.5.0
• Assignee: Fero Szabo
• Reporter: Zoltán Tóth
• Created: 01/Sep/17 12:32
• Updated: 08/Dec/17 16:38
• Resolved: 08/Dec/17 10:48

Description

I found an issue in SqoopHCatImportHelper.convertNumberTypes method. In the if block it checks for VARCHAR type and in the if else statement it does the same but should be a CHAR check.

org.apache.sqoop.mapreduce.hcat.SqoopHCatImportHelper.convertNumberTypes

if (hfsType == HCatFieldSchema.Type.VARCHAR) {
        VarcharTypeInfo vti = (VarcharTypeInfo) hfs.getTypeInfo();
        HiveVarchar hvc = new HiveVarchar(bdStr, vti.getLength());
        return hvc;
      } else if (hfsType == HCatFieldSchema.Type.VARCHAR) {
        CharTypeInfo cti = (CharTypeInfo) hfs.getTypeInfo();
        HiveChar hChar = new HiveChar(bdStr, cti.getLength());
        return hChar;
      } else {
        return bdStr;
      }

Issue Links

• links to: Review