Sqoop
  1. Sqoop
  2. SQOOP-320

Use Information Schema for SQLServerManager

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1592/
        -----------------------------------------------------------

        Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.

        Summary
        -------

        Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.

        This addresses bug SQOOP-320.
        https://issues.apache.org/jira/browse/SQOOP-320

        Diffs


        src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af

        Diff: https://reviews.apache.org/r/1592/diff

        Testing
        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1592/ ----------------------------------------------------------- Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar. Summary ------- Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager. This addresses bug SQOOP-320 . https://issues.apache.org/jira/browse/SQOOP-320 Diffs src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af Diff: https://reviews.apache.org/r/1592/diff Testing ------- Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1592/#review1558
        -----------------------------------------------------------

        Ship it!

        +1

        Can you please add the patch to the Jira. Thanks!

        • Arvind

        On 2011-08-19 18:02:31, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1592/

        -----------------------------------------------------------

        (Updated 2011-08-19 18:02:31)

        Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.

        Summary

        -------

        Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.

        This addresses bug SQOOP-320.

        https://issues.apache.org/jira/browse/SQOOP-320

        Diffs

        -----

        src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af

        Diff: https://reviews.apache.org/r/1592/diff

        Testing

        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1592/#review1558 ----------------------------------------------------------- Ship it! +1 Can you please add the patch to the Jira. Thanks! Arvind On 2011-08-19 18:02:31, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1592/ ----------------------------------------------------------- (Updated 2011-08-19 18:02:31) Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar. Summary ------- Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager. This addresses bug SQOOP-320 . https://issues.apache.org/jira/browse/SQOOP-320 Diffs ----- src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af Diff: https://reviews.apache.org/r/1592/diff Testing ------- Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-08-19 20:04:25, Arvind Prabhakar wrote:

        > +1

        >

        > Can you please add the patch to the Jira. Thanks!

        Ok. Done.

        • Bilung

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1592/#review1558
        -----------------------------------------------------------

        On 2011-08-19 18:02:31, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1592/

        -----------------------------------------------------------

        (Updated 2011-08-19 18:02:31)

        Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar.

        Summary

        -------

        Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager.

        This addresses bug SQOOP-320.

        https://issues.apache.org/jira/browse/SQOOP-320

        Diffs

        -----

        src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af

        Diff: https://reviews.apache.org/r/1592/diff

        Testing

        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-08-19 20:04:25, Arvind Prabhakar wrote: > +1 > > Can you please add the patch to the Jira. Thanks! Ok. Done. Bilung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1592/#review1558 ----------------------------------------------------------- On 2011-08-19 18:02:31, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1592/ ----------------------------------------------------------- (Updated 2011-08-19 18:02:31) Review request for Sqoop, Ahmed Radwan and Arvind Prabhakar. Summary ------- Use queries directly on information schema to retrieve information, such as database list, table list, column list, and primary key column, for SQLServerManager. This addresses bug SQOOP-320 . https://issues.apache.org/jira/browse/SQOOP-320 Diffs ----- src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af Diff: https://reviews.apache.org/r/1592/diff Testing ------- Thanks, Bilung
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Bilung!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Bilung!
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #15 (See https://builds.apache.org/job/Sqoop-jdk-1.6/15/)
        SQOOP-320. Use Information Schema for SQLServer.

        (Bilung Lee via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1159949
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/SQLServerManager.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #15 (See https://builds.apache.org/job/Sqoop-jdk-1.6/15/ ) SQOOP-320 . Use Information Schema for SQLServer. (Bilung Lee via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1159949 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/SQLServerManager.java

          People

          • Assignee:
            Bilung Lee
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development