Sqoop
  1. Sqoop
  2. SQOOP-311

change java package from com.cloudera.sqoop to org.apache.sqoop

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Alex Newman added a comment -

        Closing out SQOOP-333 as a dup. Take a look at the patches I plopped in 344. If you don't think that approach will work lets work something else out. We can have all of the classes go through an interface shim, but I think this approach should work.

        Show
        Alex Newman added a comment - Closing out SQOOP-333 as a dup. Take a look at the patches I plopped in 344. If you don't think that approach will work lets work something else out. We can have all of the classes go through an interface shim, but I think this approach should work.
        Hide
        Alex Newman added a comment -

        So I have created shim classes for all of lib and ConnManager, and marked them as deprecated. Everything else is in org.apache.sqoop.

        Show
        Alex Newman added a comment - So I have created shim classes for all of lib and ConnManager, and marked them as deprecated. Everything else is in org.apache.sqoop.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        Oh yes for sure. Sorry didn't have time to work on last weeks.

        Show
        Olivier Lamy (*$^¨%`£) added a comment - Oh yes for sure. Sorry didn't have time to work on last weeks.
        Hide
        Alex Newman added a comment -

        Olivier I think I have this done. Can I reassign to myself?

        Show
        Alex Newman added a comment - Olivier I think I have this done. Can I reassign to myself?
        Hide
        Alex Newman added a comment -

        Anyway I can just make them all just shim classes marked as deprecated? That should keep backwards comparability?

        Show
        Alex Newman added a comment - Anyway I can just make them all just shim classes marked as deprecated? That should keep backwards comparability?
        Hide
        Arvind Prabhakar added a comment -

        Correct - the public API (lib package as well as the ConnManager hierarchy) should continue to exist in their original namespace but in a deprecated state. These and other deprecated APIs can then be removed in the following major revision.

        Show
        Arvind Prabhakar added a comment - Correct - the public API (lib package as well as the ConnManager hierarchy) should continue to exist in their original namespace but in a deprecated state. These and other deprecated APIs can then be removed in the following major revision.
        Hide
        Jonathan Hsieh added a comment -

        One other thought –

        This is likely going to break backwards compatibility with old sqoop codegen jars and other connection manager plugins. Is keeping some com.cloudera stuff around (at least until the next major version of sqoop) going to be acceptable?

        Show
        Jonathan Hsieh added a comment - One other thought – This is likely going to break backwards compatibility with old sqoop codegen jars and other connection manager plugins. Is keeping some com.cloudera stuff around (at least until the next major version of sqoop) going to be acceptable?
        Hide
        Jonathan Hsieh added a comment -

        There are enough +1s so I just changed the task summary.

        Show
        Jonathan Hsieh added a comment - There are enough +1s so I just changed the task summary.
        Hide
        Arvind Prabhakar added a comment -

        agree.

        Show
        Arvind Prabhakar added a comment - agree.
        Hide
        Patrick Hunt added a comment -

        agree.

        Show
        Patrick Hunt added a comment - agree.
        Hide
        Olivier Lamy (*$^¨%`£) added a comment -

        agree

        Show
        Olivier Lamy (*$^¨%`£) added a comment - agree
        Hide
        Jonathan Hsieh added a comment -

        Since the goal is to make sqoop a TLP (not a hadoop subproject), I think I'd prefer the package be changed to org.apache.sqoop instead. Agree?

        Most project seem to have gone this way:

        • Zookeeper is org.apache.zookeeper
        • Pig is org.apache.pig
        • HCatalog is org.apache.hcatalog
        • Oozie is org.apache.oozie
        • Mahout is org.apache.mahout

        There are of course a few exceptions:

        • Hbase is org.apache.hadoop.hbase
        • Hive is org.apache.hadoop.hive
        Show
        Jonathan Hsieh added a comment - Since the goal is to make sqoop a TLP (not a hadoop subproject), I think I'd prefer the package be changed to org.apache.sqoop instead. Agree? Most project seem to have gone this way: Zookeeper is org.apache.zookeeper Pig is org.apache.pig HCatalog is org.apache.hcatalog Oozie is org.apache.oozie Mahout is org.apache.mahout There are of course a few exceptions: Hbase is org.apache.hadoop.hbase Hive is org.apache.hadoop.hive

          People

          • Assignee:
            Alex Newman
            Reporter:
            Olivier Lamy (*$^¨%`£)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development