[SQOOP-2823] Sqoop2: RESTiliency: Remove repetitive try-catch block for accessing POST and PUT request

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.99.7
• Assignee: Jarek Jarcec Cecho
• Reporter: Jarek Jarcec Cecho
• Created: 05/Feb/16 23:21
• Updated: 19/Feb/16 15:21
• Resolved: 19/Feb/16 15:21

Description

I've noticed that we have quite a few repetition of code like this one:

     RoleBean bean = new RoleBean();

    try {
      JSONObject json = JSONUtils.parse(ctx.getRequest().getReader());
      bean.restore(json);
    } catch (IOException e) {
      throw new SqoopException(ServerError.SERVER_0003, "Can't read request content", e);
    }

It's relatively a lot of code just because ctx.getRequest() can throw an exception. I would like to propose to create a method in our ctx wrapper to provide the getReader method without any exception, which will simplify the code to:

    bean.restore(JSONUtils.parse(ctx.getReader()));

We'll of course throw an exception on failure - but using our SqoopException mechanism.

Issue Links

• links to: Review board