[SQOOP-1784] Sqoop2: Sending POST request to link or job end-point might end up with NPE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.99.4
• Fix Version/s: 1.99.5
• Assignee: Jarek Jarcec Cecho
• Reporter: Jarek Jarcec Cecho
• Created: 23/Nov/14 04:07
• Updated: 26/Mar/15 07:25
• Resolved: 24/Nov/14 05:40

Description

I was testing few patches on real cluster and noticed that creating link on current head of sqoop2 branch can lead to NPE in LinkBean. I've traced the code and found out that ctx.getRequest().getReader() is returning empty buffer and as a result the subsequent call to JSONValue.parse returns null and we hit NullPointerException later in LInkBean.

This one was quite hard to crack, but I believe that I've isolated the problem. In SQOOP-1774 we've changed the way to get username from header to URL parameter and we're using ServletRequest.getParameter() method for that. Carefully reading it's javadoc I found out that:

If the parameter data was sent in the request body, such as occurs with an HTTP POST request, then reading the body directly via getInputStream() or getReader() can interfere with the execution of this method

And hence I'm assuming that getting the username has processed the request body already and thus we got the eventual NullPointerException.

Sub-Tasks

• Sqoop2: Sqoop-server request handlers have ZERO unit tests: Resolved
• Sqoop2: Retrieve Http post data in plausible manner: Resolved