[SQOOP-1605] Sqoop2: Misc From/to cleanups

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.99.4
• Fix Version/s: 1.99.4
• Assignee: Abraham Elmahrek
• Reporter: Veena Basavaraj
• Created: 22/Oct/14 20:36
• Updated: 13/Jan/15 22:11
• Resolved: 27/Oct/14 19:51

Description

 //Job Manager
     if (lastSubmission != null && lastSubmission.getStatus().isRunning()) {
        throw new SqoopException(DriverError.DRIVER_0002, "Job with id " + jobId);
      }
      // TODO(Abe): Call multiple destroyers.
      // TODO(jarcec): We might need to catch all exceptions here to ensure
      // that Destroyer will be executed in all cases.
      // NOTE: the following is a blocking call
      boolean success = submissionEngine.submit(jobRequest);
      if (!success) {
    

// TestJdbcRepository
  upgraderOrder.verifyNoMoreInteractions();
    validatorOrder.verify(validatorMock, times(2)).validateConfigForLink(anyObject());
    // @TODO(Abe): Re-enable job validation?
    validatorOrder.verify(validatorMock, times(0)).validateConfigForJob(anyObject());
    validatorOrder.verifyNoMoreInteractions();
  

//JobRequestHandler

      // Add associated resources into the bean
      // @TODO(Abe): From/To.
      for( MJob job : jobs) {
        long connectorId = job.getConnectorId(Direction.FROM);
        if(!bean.hasConnectorConfigBundle(connectorId)) {
          bean.addConnectorConfigBundle(connectorId,
   

// some test code ( jarcec might fix this in his validator code)
   
 // @TODO(Abe): From/To.
   ResourceBundle fromConfigBundle = client.getConnectorConfigBundle(
       job.getConnectorId(Direction.FROM));
 upgraderOrder.verifyNoMoreInteractions();
   validatorOrder.verify(validatorMock, times(2)).validateConfigForLink(anyObject());

   // @TODO(Abe): Re-enable job validation?
   validatorOrder.verify(validatorMock, times(0)).validateConfigForJob(anyObject());

//Mapreduce Submission Engine
 MRConfigurationUtils.setConnectorJobConfig(Direction.FROM, job, request.getJobConfig(Direction.FROM));
      MRConfigurationUtils.setConnectorJobConfig(Direction.TO, job, request.getJobConfig(Direction.TO));

      MRConfigurationUtils.setDriverConfig(job, request.getDriverConfig());
      // @TODO(Abe): Persist TO schema.
      MRConfigurationUtils.setConnectorSchema(Direction.FROM, job, request.getSummary().getFromSchema());
      MRConfigurationUtils.setConnectorSchema(Direction.TO, job, request.getSummary().getToSchema());

Issue Links

• links to: RB