Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.4
    • Fix Version/s: 1.99.5
    • Labels:
      None

      Description

      Implement PostgresqlRepositoryHandler and all the required dependent classes.

      1. SQOOP-1590.2.patch
        84 kB
        Abraham Elmahrek
      2. SQOOP-1590.3.patch
        80 kB
        Abraham Elmahrek
      3. SQOOP-1590.4.patch
        58 kB
        Abraham Elmahrek
      4. SQOOP-1590.5.patch
        58 kB
        Abraham Elmahrek
      5. SQOOP-1590.6.patch
        58 kB
        Abraham Elmahrek
      6. SQOOP-1590.7.patch
        58 kB
        Abraham Elmahrek
      7. SQOOP-1590.DOES-NOT-APPLY-0.patch
        65 kB
        Abraham Elmahrek

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop200 #683 (See https://builds.apache.org/job/Sqoop2-hadoop200/683/)
          SQOOP-1590: Sqoop2: PostgreSQL repository implementation (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=fdc40d39c6b05c1c62de676596dfb14aff852d3b)

          • common-test/pom.xml
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
          • repository/repository-postgresql/src/test/resources/log4j.properties
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java
          • repository/pom.xml
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
          • common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
          • repository/repository-postgresql/pom.xml
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
          • repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
          • server/pom.xml
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
          • pom.xml
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop200 #683 (See https://builds.apache.org/job/Sqoop2-hadoop200/683/ ) SQOOP-1590 : Sqoop2: PostgreSQL repository implementation (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=fdc40d39c6b05c1c62de676596dfb14aff852d3b ) common-test/pom.xml core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java repository/repository-postgresql/src/test/resources/log4j.properties repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java repository/pom.xml repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java repository/repository-postgresql/pom.xml repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java server/pom.xml repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java pom.xml repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Sqoop2-hadoop100 #752 (See https://builds.apache.org/job/Sqoop2-hadoop100/752/)
          SQOOP-1590: Sqoop2: PostgreSQL repository implementation (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=fdc40d39c6b05c1c62de676596dfb14aff852d3b)

          • common-test/pom.xml
          • repository/pom.xml
          • repository/repository-postgresql/pom.xml
          • common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java
          • pom.xml
          • repository/repository-postgresql/src/test/resources/log4j.properties
          • server/pom.xml
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
          • repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
          • repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
          • repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Sqoop2-hadoop100 #752 (See https://builds.apache.org/job/Sqoop2-hadoop100/752/ ) SQOOP-1590 : Sqoop2: PostgreSQL repository implementation (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=fdc40d39c6b05c1c62de676596dfb14aff852d3b ) common-test/pom.xml repository/pom.xml repository/repository-postgresql/pom.xml common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java pom.xml repository/repository-postgresql/src/test/resources/log4j.properties server/pom.xml core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          My apologies for committing this one late Abraham Elmahrek, thank you for your effort!

          Show
          jarcec Jarek Jarcec Cecho added a comment - My apologies for committing this one late Abraham Elmahrek , thank you for your effort!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fdc40d39c6b05c1c62de676596dfb14aff852d3b in sqoop's branch refs/heads/sqoop2 from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=fdc40d3 ]

          SQOOP-1590: Sqoop2: PostgreSQL repository implementation

          (Abraham Elmahrek via Jarek Jarcec Cecho)

          Show
          jira-bot ASF subversion and git services added a comment - Commit fdc40d39c6b05c1c62de676596dfb14aff852d3b in sqoop's branch refs/heads/sqoop2 from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=fdc40d3 ] SQOOP-1590 : Sqoop2: PostgreSQL repository implementation (Abraham Elmahrek via Jarek Jarcec Cecho)
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Testing file SQOOP-1590.7.patch against branch sqoop2 took 0:26:21.042293.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: License check passed
          SUCCESS: Patch compiled
          SUCCESS: All unit tests passed
          SUCCESS: All integration tests passed

          Console output is available here.

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Testing file SQOOP-1590.7.patch against branch sqoop2 took 0:26:21.042293. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: License check passed SUCCESS: Patch compiled SUCCESS: All unit tests passed SUCCESS: All integration tests passed Console output is available here . This message is automatically generated.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Testing file SQOOP-1590.6.patch against branch sqoop2 took 0:26:11.253708.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: License check passed
          SUCCESS: Patch compiled
          SUCCESS: All unit tests passed
          SUCCESS: All integration tests passed

          Console output is available here.

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Testing file SQOOP-1590.6.patch against branch sqoop2 took 0:26:11.253708. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: License check passed SUCCESS: Patch compiled SUCCESS: All unit tests passed SUCCESS: All integration tests passed Console output is available here . This message is automatically generated.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Testing file SQOOP-1590.5.patch against branch sqoop2 took 0:00:41.691748.

          Overall: -1 due to an error

          ERROR: failed to build with patch (exit code 1)
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: License check passed

          Console output is available here.

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Testing file SQOOP-1590.5.patch against branch sqoop2 took 0:00:41.691748. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: License check passed Console output is available here . This message is automatically generated.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Testing file SQOOP-1590.5.patch against branch sqoop2 took 0:00:11.861660.

          Overall: -1 due to an error

          ERROR: Failed to run license check (exit code 1)
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case

          Console output is available here.

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Testing file SQOOP-1590.5.patch against branch sqoop2 took 0:00:11.861660. Overall: -1 due to an error ERROR: Failed to run license check (exit code 1) SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case Console output is available here . This message is automatically generated.
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          Just a note that SQOOP-1896 is changing method isRespositorySuitableForUse to isRepositorySuitableForUse (fixing typo). I believe that this patch will be affected as well.

          Show
          jarcec Jarek Jarcec Cecho added a comment - Just a note that SQOOP-1896 is changing method isRespositorySuitableForUse to isRepositorySuitableForUse (fixing typo). I believe that this patch will be affected as well.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Testing file SQOOP-1590.4.patch against branch sqoop2 took 0:23:17.498180.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: Patch compiled
          SUCCESS: All unit tests passed
          SUCCESS: All integration tests passed

          Console output is available here.

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Testing file SQOOP-1590.4.patch against branch sqoop2 took 0:23:17.498180. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: Patch compiled SUCCESS: All unit tests passed SUCCESS: All integration tests passed Console output is available here . This message is automatically generated.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12684691/SQOOP-1590.3.patch against branch sqoop2.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: Patch compiled
          SUCCESS: All unit tests passed
          SUCCESS: All integration tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/689/console

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12684691/SQOOP-1590.3.patch against branch sqoop2. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: Patch compiled SUCCESS: All unit tests passed SUCCESS: All integration tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/689/console This message is automatically generated.
          Hide
          abec Abraham Elmahrek added a comment -

          Above errors seem oriented around Derby server not starting... rerunning build to see if that fixes things.

          Show
          abec Abraham Elmahrek added a comment - Above errors seem oriented around Derby server not starting... rerunning build to see if that fixes things.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12684691/SQOOP-1590.3.patch against branch sqoop2.

          Overall: -1 due to 3 errors

          ERROR: Some integration tests failed
          ERROR: Failed integration test: org.apache.sqoop.integration.connector.jdbc.generic.FromHDFSToRDBMSTest
          ERROR: Failed integration test: org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: Patch compiled
          SUCCESS: All unit tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/688/console

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12684691/SQOOP-1590.3.patch against branch sqoop2. Overall: -1 due to 3 errors ERROR: Some integration tests failed ERROR: Failed integration test: org.apache.sqoop.integration.connector.jdbc.generic.FromHDFSToRDBMSTest ERROR: Failed integration test: org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: Patch compiled SUCCESS: All unit tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/688/console This message is automatically generated.
          Hide
          sqoop-qa Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12684528/SQOOP-1590.2.patch against branch sqoop2.

          Overall: -1 due to an error

          ERROR: failed to build with patch (exit code 1)
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/685/console

          This message is automatically generated.

          Show
          sqoop-qa Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12684528/SQOOP-1590.2.patch against branch sqoop2. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/685/console This message is automatically generated.
          Hide
          abec Abraham Elmahrek added a comment -

          With SQOOP-1589, this simplifies a bit... but I cannot update the review board yet... providing a patch that will not apply until SQOOP-1589 is in.

          Show
          abec Abraham Elmahrek added a comment - With SQOOP-1589 , this simplifies a bit... but I cannot update the review board yet... providing a patch that will not apply until SQOOP-1589 is in.
          Hide
          abec Abraham Elmahrek added a comment -

          Initial RB up... without real tests yet. Please provide feedback.

          Show
          abec Abraham Elmahrek added a comment - Initial RB up... without real tests yet. Please provide feedback.

            People

            • Assignee:
              abec Abraham Elmahrek
              Reporter:
              abec Abraham Elmahrek
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development