Sqoop
  1. Sqoop
  2. SQOOP-1264

Sqoop2: Remove unnecessary cd command calls from sqoop.sh

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.99.3
    • Fix Version/s: 1.99.4
    • Component/s: None
    • Labels:
      None

      Description

      It seems that we are unnecessary changing directory inside the sqoop.sh script, so that we can work with relative paths. It seems to me that this is some sort of heritage from older versions of the script, so I would propose to remove the cd command and work with absolute paths only.

      1. SQOOP-1264.patch
        1 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12620511/SQOOP-1264.patch against branch sqoop2.

          Overall: -1 due to 2 errors

          ERROR: failed to build with patch (exit code 1)
          ERROR: Patch does not add/modifny any test case
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/213/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12620511/SQOOP-1264.patch against branch sqoop2. Overall: -1 due to 2 errors ERROR: failed to build with patch (exit code 1) ERROR: Patch does not add/modifny any test case SUCCESS: Clean was successful SUCCESS: Patch applied correctly Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/213/console This message is automatically generated.
          Hide
          Jarek Jarcec Cecho added a comment -

          ERROR: failed to build with patch (exit code 1)

          This is a jenkins glitch, maven can't find it's own files.

          ERROR: Patch does not add/modifny any test case

          This is a shell script only change, hence no test case attached.

          Show
          Jarek Jarcec Cecho added a comment - ERROR: failed to build with patch (exit code 1) This is a jenkins glitch, maven can't find it's own files. ERROR: Patch does not add/modifny any test case This is a shell script only change, hence no test case attached.
          Hide
          Sean Mackrory added a comment -

          +1 (non-committer). This makes it safer in an Apache Bigtop context to run this script as the "sqoop2" user, since they may not have permission to cd into the directories of the user invoking the command.

          Show
          Sean Mackrory added a comment - +1 (non-committer). This makes it safer in an Apache Bigtop context to run this script as the "sqoop2" user, since they may not have permission to cd into the directories of the user invoking the command.
          Hide
          ASF subversion and git services added a comment -

          Commit ad93e2a5e89ff1d434059a32c20bc53b5c4d4175 in branch refs/heads/sqoop2 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=ad93e2a ]

          SQOOP-1264. Sqoop2: Remove unnecessary cd command calls from sqoop.sh

          (Jarek Jarcec Cecho via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit ad93e2a5e89ff1d434059a32c20bc53b5c4d4175 in branch refs/heads/sqoop2 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=ad93e2a ] SQOOP-1264 . Sqoop2: Remove unnecessary cd command calls from sqoop.sh (Jarek Jarcec Cecho via Hari Shreedharan)
          Hide
          Hari Shreedharan added a comment -

          Committed! Thanks Jarcec!

          Show
          Hari Shreedharan added a comment - Committed! Thanks Jarcec!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/)
          SQOOP-1264. Sqoop2: Remove unnecessary cd command calls from sqoop.sh (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=ad93e2a5e89ff1d434059a32c20bc53b5c4d4175)

          • dist/src/main/bin/sqoop.sh
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/ ) SQOOP-1264 . Sqoop2: Remove unnecessary cd command calls from sqoop.sh (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=ad93e2a5e89ff1d434059a32c20bc53b5c4d4175 ) dist/src/main/bin/sqoop.sh
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/)
          SQOOP-1264. Sqoop2: Remove unnecessary cd command calls from sqoop.sh (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=ad93e2a5e89ff1d434059a32c20bc53b5c4d4175)

          • dist/src/main/bin/sqoop.sh
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/ ) SQOOP-1264 . Sqoop2: Remove unnecessary cd command calls from sqoop.sh (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=ad93e2a5e89ff1d434059a32c20bc53b5c4d4175 ) dist/src/main/bin/sqoop.sh

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development