Sqoop
  1. Sqoop
  2. SQOOP-1247

Sqoop2: Distribution module is missing dependency on Tomcat module

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.99.3
    • Fix Version/s: 1.99.4
    • Component/s: None
    • Labels:
      None

      Description

      Binary packaging build has started failing after committing SQOOP-1232. The problem seems to be in the order the modules are built:

      [INFO] Sqoop Distribution ................................ FAILURE [27.344s]
      [INFO] Sqoop Integration Tests ........................... SKIPPED
      [INFO] Sqoop Tomcat additions ............................ SKIPPED
      

      The distribution module is built before the Tomcat module, but that should not be the case as the distribution module do have a dependency on tomcat module. It seems that I've missed adding this dependency to the pom files when working on SQOOP-1232. From whatever reason maven used different order for building the modules at that time and as a result this has slipped me.

      1. SQOOP-1247.patch
        1 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Sqoop2-hadoop100 #595 (See https://builds.apache.org/job/Sqoop2-hadoop100/595/)
        SQOOP-1247. Sqoop2: Add sqoop-tomcat dependency to distribution module. (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3e4107f2581af089c7ff21ef574c91d13b77f1d4)

        • dist/pom.xml
        • pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop100 #595 (See https://builds.apache.org/job/Sqoop2-hadoop100/595/ ) SQOOP-1247 . Sqoop2: Add sqoop-tomcat dependency to distribution module. (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3e4107f2581af089c7ff21ef574c91d13b77f1d4 ) dist/pom.xml pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Sqoop2-hadoop200 #529 (See https://builds.apache.org/job/Sqoop2-hadoop200/529/)
        SQOOP-1247. Sqoop2: Add sqoop-tomcat dependency to distribution module. (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3e4107f2581af089c7ff21ef574c91d13b77f1d4)

        • dist/pom.xml
        • pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop200 #529 (See https://builds.apache.org/job/Sqoop2-hadoop200/529/ ) SQOOP-1247 . Sqoop2: Add sqoop-tomcat dependency to distribution module. (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3e4107f2581af089c7ff21ef574c91d13b77f1d4 ) dist/pom.xml pom.xml
        Hari Shreedharan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hari Shreedharan added a comment -

        Committed. Thanks Jarek!

        Show
        Hari Shreedharan added a comment - Committed. Thanks Jarek!
        Hide
        ASF subversion and git services added a comment -

        Commit 3e4107f2581af089c7ff21ef574c91d13b77f1d4 in branch refs/heads/sqoop2 from Hari Shreedharan
        [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=3e4107f ]

        SQOOP-1247. Sqoop2: Add sqoop-tomcat dependency to distribution module.

        (Jarek Jarcec Cecho via Hari Shreedharan)

        Show
        ASF subversion and git services added a comment - Commit 3e4107f2581af089c7ff21ef574c91d13b77f1d4 in branch refs/heads/sqoop2 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=3e4107f ] SQOOP-1247 . Sqoop2: Add sqoop-tomcat dependency to distribution module. (Jarek Jarcec Cecho via Hari Shreedharan)
        Hide
        Hari Shreedharan added a comment -

        +1.

        Show
        Hari Shreedharan added a comment - +1.
        Hide
        Sqoop QA bot added a comment -

        Here are the results of testing the latest attachment
        https://issues.apache.org/jira/secure/attachment/12616996/SQOOP-1247.patch against branch sqoop2.

        Overall: -1 due to an error

        ERROR: Patch does not add/modifny any test case
        SUCCESS: Clean was successful
        SUCCESS: Patch applied correctly
        SUCCESS: Patch compiled
        SUCCESS: All tests passed

        Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/204/console

        This message is automatically generated.

        Show
        Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12616996/SQOOP-1247.patch against branch sqoop2. Overall: -1 due to an error ERROR: Patch does not add/modifny any test case SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/204/console This message is automatically generated.
        Jarek Jarcec Cecho made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 1.99.4 [ 12324987 ]
        Jarek Jarcec Cecho made changes -
        Attachment SQOOP-1247.patch [ 12616996 ]
        Jarek Jarcec Cecho made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Blocker [ 1 ]
        Jarek Jarcec Cecho created issue -

          People

          • Assignee:
            Jarek Jarcec Cecho
            Reporter:
            Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development