Sqoop
  1. Sqoop
  2. SQOOP-1234

Sqoop2: Clean up comments in MSubmission class

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.3
    • Fix Version/s: 1.99.4
    • Component/s: None
    • Labels:
      None

      Description

      There is couple of outdated comments, so we should clean it up.

      1. SQOOP-1234.patch
        3 kB
        Jarek Jarcec Cecho
      2. SQOOP-1234.patch
        3 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12614321/SQOOP-1234.patch against branch sqoop2.

          Overall: -1 due to 2 errors

          ERROR: failed to build with patch (exit code 1)
          ERROR: Patch does not add/modifny any test case
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/187/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12614321/SQOOP-1234.patch against branch sqoop2. Overall: -1 due to 2 errors ERROR: failed to build with patch (exit code 1) ERROR: Patch does not add/modifny any test case SUCCESS: Clean was successful SUCCESS: Patch applied correctly Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/187/console This message is automatically generated.
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12614411/SQOOP-1234.patch against branch sqoop2.

          Overall: -1 due to an error

          ERROR: Patch does not add/modifny any test case
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/191/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12614411/SQOOP-1234.patch against branch sqoop2. Overall: -1 due to an error ERROR: Patch does not add/modifny any test case SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/191/console This message is automatically generated.
          Hide
          Hari Shreedharan added a comment -

          +1. Committing

          Show
          Hari Shreedharan added a comment - +1. Committing
          Hide
          ASF subversion and git services added a comment -

          Commit 30581fb4e5dec1e4b46945deb4795f8950414dce in branch refs/heads/sqoop2 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=30581fb ]

          SQOOP-1234. Sqoop2: Clean up comments in MSubmission class

          (Jarek Jarcec Cecho via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit 30581fb4e5dec1e4b46945deb4795f8950414dce in branch refs/heads/sqoop2 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=30581fb ] SQOOP-1234 . Sqoop2: Clean up comments in MSubmission class (Jarek Jarcec Cecho via Hari Shreedharan)
          Hide
          Hari Shreedharan added a comment -

          Committed! Thanks Jarcec!

          Show
          Hari Shreedharan added a comment - Committed! Thanks Jarcec!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/)
          SQOOP-1234. Sqoop2: Clean up comments in MSubmission class (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=30581fb4e5dec1e4b46945deb4795f8950414dce)

          • common/src/main/java/org/apache/sqoop/model/MSubmission.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/ ) SQOOP-1234 . Sqoop2: Clean up comments in MSubmission class (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=30581fb4e5dec1e4b46945deb4795f8950414dce ) common/src/main/java/org/apache/sqoop/model/MSubmission.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/)
          SQOOP-1234. Sqoop2: Clean up comments in MSubmission class (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=30581fb4e5dec1e4b46945deb4795f8950414dce)

          • common/src/main/java/org/apache/sqoop/model/MSubmission.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/ ) SQOOP-1234 . Sqoop2: Clean up comments in MSubmission class (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=30581fb4e5dec1e4b46945deb4795f8950414dce ) common/src/main/java/org/apache/sqoop/model/MSubmission.java

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development