Sqoop
  1. Sqoop
  2. SQOOP-1145

Sqoop2: Use JSON object for serializing MAP input type

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:
      None

      Description

      For server to client communication

      1. SQOOP-1145.2.patch
        7 kB
        Abraham Elmahrek
      2. SQOOP-1145.1.patch
        6 kB
        Abraham Elmahrek
      3. SQOOP-1145.0.patch
        38 kB
        Abraham Elmahrek

        Issue Links

          Activity

          Abraham Elmahrek created issue -
          Abraham Elmahrek made changes -
          Field Original Value New Value
          Assignee Abraham Elmahrek [ abec ]
          Affects Version/s 1.99.2 [ 12323640 ]
          Description For server to client communication
          Hide
          Abraham Elmahrek added a comment - - edited

          It seems like we should change the "String MInput#getUrlSafeValueString()" interface to be "T MInput#getUrlSafeValue()". The JSONObject type seems to be able to handle most primitive types, array-like collections, and maps.

          Similarly, we'd have to changerestorFromUrlSafeValueString.

          Show
          Abraham Elmahrek added a comment - - edited It seems like we should change the "String MInput#getUrlSafeValueString()" interface to be "T MInput#getUrlSafeValue()". The JSONObject type seems to be able to handle most primitive types, array-like collections, and maps. Similarly, we'd have to changerestorFromUrlSafeValueString.
          Hide
          Abraham Elmahrek added a comment -

          Keeping previous model, except changing FormSerialization.

          Show
          Abraham Elmahrek added a comment - Keeping previous model, except changing FormSerialization.
          Abraham Elmahrek made changes -
          Attachment SQOOP-1145.0.patch [ 12593753 ]
          Jarek Jarcec Cecho made changes -
          Remote Link This issue links to "Review board (Web Link)" [ 12433 ]
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12593753/SQOOP-1145.0.patch against branch sqoop2.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/85/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12593753/SQOOP-1145.0.patch against branch sqoop2. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/85/console This message is automatically generated.
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12593753/SQOOP-1145.0.patch against branch sqoop2.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/86/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12593753/SQOOP-1145.0.patch against branch sqoop2. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/86/console This message is automatically generated.
          Abraham Elmahrek made changes -
          Attachment SQOOP-1145.1.patch [ 12594474 ]
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12594474/SQOOP-1145.1.patch against branch sqoop2.

          Overall: -1 due to an error

          ERROR: failed to build with patch (exit code 1)
          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/93/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12594474/SQOOP-1145.1.patch against branch sqoop2. Overall: -1 due to an error ERROR: failed to build with patch (exit code 1) SUCCESS: Clean was successful SUCCESS: Patch applied correctly Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/93/console This message is automatically generated.
          Abraham Elmahrek made changes -
          Attachment SQOOP-1145.2.patch [ 12594544 ]
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12594544/SQOOP-1145.2.patch against branch sqoop2.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/94/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12594544/SQOOP-1145.2.patch against branch sqoop2. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/94/console This message is automatically generated.
          Hide
          ASF subversion and git services added a comment -

          Commit 9f8ac6b6b27d1fc1f29e7521a6fb6f18884fc4f8 in branch refs/heads/sqoop2 from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=9f8ac6b ]

          SQOOP-1145: Sqoop2: Use JSON object for serializing MAP input type

          (Abraham Elmahrek via Jarek Jarcec Cecho)

          Show
          ASF subversion and git services added a comment - Commit 9f8ac6b6b27d1fc1f29e7521a6fb6f18884fc4f8 in branch refs/heads/sqoop2 from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=9f8ac6b ] SQOOP-1145 : Sqoop2: Use JSON object for serializing MAP input type (Abraham Elmahrek via Jarek Jarcec Cecho)
          Hide
          Jarek Jarcec Cecho added a comment -

          Thank you Abraham Elmahrek for your contribution!

          Show
          Jarek Jarcec Cecho added a comment - Thank you Abraham Elmahrek for your contribution!
          Jarek Jarcec Cecho made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 1.99.3 [ 12324298 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Abraham Elmahrek
              Reporter:
              Abraham Elmahrek
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development