Sqoop
  1. Sqoop
  2. SQOOP-1135

Sqoop2: Rename queries in Derby repository to have the same naming scheme

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.4
    • Component/s: None
    • Labels:

      Description

      Currently we have constants for query creation in Derby repository using QUERY_CREATE_TABLE_SQ_TBLNAME including the SQ_ prefix (for example QUERY_CREATE_TABLE_SQ_SYSTEM. However other queries like INSERT or SELECT are referring the tables without the SQ_ prefix. I think that it would be helpful to be consistent

      1. SQOOP-1135.patch
        38 kB
        Vasanth kumar RJ

        Issue Links

          Activity

          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12592988/SQOOP-1135.patch against branch sqoop2.

          Overall: -1 due to an error

          ERROR: failed to apply patch (exit code 1):

          error: repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java: No such file or directory
          error: repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java: No such file or directory
          

          SUCCESS: Clean was successful

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/75/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12592988/SQOOP-1135.patch against branch sqoop2. Overall: -1 due to an error ERROR: failed to apply patch (exit code 1): error: repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java: No such file or directory error: repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java: No such file or directory SUCCESS: Clean was successful Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/75/console This message is automatically generated.
          Hide
          Jarek Jarcec Cecho added a comment -

          Hi Vasanth kumar RJ,
          it seems that you've created patch with git diff --no-prefix. Please regenerate the patch with git diff (e.g. without --no-prefix).

          Jarcec

          Show
          Jarek Jarcec Cecho added a comment - Hi Vasanth kumar RJ , it seems that you've created patch with git diff --no-prefix . Please regenerate the patch with git diff (e.g. without --no-prefix ). Jarcec
          Hide
          Jarek Jarcec Cecho added a comment -

          We are currently waiting on incorporating review suggestions into the patch, so I'm cancelling the "Patch available" state to clean up review queue.

          Show
          Jarek Jarcec Cecho added a comment - We are currently waiting on incorporating review suggestions into the patch, so I'm cancelling the "Patch available" state to clean up review queue.

            People

            • Assignee:
              Vasanth kumar RJ
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development