Sqoop
  1. Sqoop
  2. SQOOP-1012

Sqoop2: Generic JDBC Connector should have one static instance of validator

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:

      Description

      Generic JDBC Connector is creating new instance of validator one every invocation of getValidator. I think that having one single instance in memory and reusing it will be effective.

      1. SQOOP-1012.patch
        1 kB
        Vasanth kumar RJ

        Issue Links

          Activity

          Show
          Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=dd3bfa3981e4496a450f59fe8e2dfef903ca65a8 Thank you Vasanth! Jarcec
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #275 (See https://builds.apache.org/job/Sqoop2-hadoop200/275/)
          SQOOP-1012: Sqoop2: Generic JDBC Connector should have one static instance of validator (Revision dd3bfa3981e4496a450f59fe8e2dfef903ca65a8)

          Result = FAILURE
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=dd3bfa3981e4496a450f59fe8e2dfef903ca65a8
          Files :

          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #275 (See https://builds.apache.org/job/Sqoop2-hadoop200/275/ ) SQOOP-1012 : Sqoop2: Generic JDBC Connector should have one static instance of validator (Revision dd3bfa3981e4496a450f59fe8e2dfef903ca65a8) Result = FAILURE jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=dd3bfa3981e4496a450f59fe8e2dfef903ca65a8 Files : connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #276 (See https://builds.apache.org/job/Sqoop2-hadoop100/276/)
          SQOOP-1012: Sqoop2: Generic JDBC Connector should have one static instance of validator (Revision dd3bfa3981e4496a450f59fe8e2dfef903ca65a8)

          Result = FAILURE
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=dd3bfa3981e4496a450f59fe8e2dfef903ca65a8
          Files :

          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #276 (See https://builds.apache.org/job/Sqoop2-hadoop100/276/ ) SQOOP-1012 : Sqoop2: Generic JDBC Connector should have one static instance of validator (Revision dd3bfa3981e4496a450f59fe8e2dfef903ca65a8) Result = FAILURE jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=dd3bfa3981e4496a450f59fe8e2dfef903ca65a8 Files : connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
          Hide
          Jarek Jarcec Cecho added a comment -

          The build failures are more Jenkins issues than a real problem, JIRA SQOOP-1026 was created to keep track of that.

          Show
          Jarek Jarcec Cecho added a comment - The build failures are more Jenkins issues than a real problem, JIRA SQOOP-1026 was created to keep track of that.

            People

            • Assignee:
              Vasanth kumar RJ
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development