[SPARK-6045] RecordWriter should be checked against null in PairRDDFunctions#saveAsNewAPIHadoopDataset

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: Input/Output
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 26/Feb/15 20:56
• Updated: 26/Feb/15 23:28
• Resolved: 26/Feb/15 23:27

Description

gtinside reported in the thread 'NullPointerException in TaskSetManager' with the following stack trace:

WARN 2015-02-26 14:21:43,217 [task-result-getter-0] TaskSetManager - Lost
task 14.2 in stage 0.0 (TID 29, devntom003.dev.blackrock.com):
java.lang.NullPointerException

org.apache.spark.rdd.PairRDDFunctions.saveAsNewAPIHadoopDataset(PairRDDFunctions.scala:1007)
com.bfm.spark.test.CassandraHadoopMigrator$.main(CassandraHadoopMigrator.scala:77)
com.bfm.spark.test.CassandraHadoopMigrator.main(CassandraHadoopMigrator.scala)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
java.lang.reflect.Method.invoke(Method.java:606)
org.apache.spark.deploy.SparkSubmit$.launch(SparkSubmit.scala:358)
org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:75)
org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)

Looks like the following call in finally block was the cause:

    writer.close(hadoopContext)

We should check writer against null before calling close().

Issue Links

• links to: [Github] Pull Request #4794 (tedyu)