[SPARK-48128] BitwiseCount / bit_count generated code for boolean inputs fails to compile

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0, 3.1.3, 3.2.4, 3.5.1, 3.3.4, 3.4.3
• Fix Version/s: 4.0.0, 3.5.2, 3.4.4
• Component/s: SQL
• Labels: pull-request-available
• Assignee: Josh Rosen
• Reporter: Josh Rosen
• Created: 04/May/24 05:46
• Updated: 04/May/24 18:55
• Resolved: 04/May/24 18:49

Description

If the `BitwiseCount` / `bit_count` expresison is applied to a boolean type column then then it will trigger codegen fallback to interpreted because the generated code contains invalid Java syntax, triggering errors like

 java.util.concurrent.ExecutionException: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 41, Column 11: Failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 41, Column 11: Unexpected token "if" in primary

This problem was masked because the QueryTest framework may not be fully exercising codegen paths (e.g. if constant folding occurs).

Issue Links

• links to: GitHub Pull Request #46382