[SPARK-4514] SparkContext localProperties does not inherit property updates across thread reuse

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.1.1, 1.2.0
• Fix Version/s: 2.0.0
• Component/s: Spark Core
• Target Version/s: 1.1.2, 1.2.1
• Assignee: Richard W. Eggert II
• Reporter: Erik Erlandson
• Created: 20/Nov/14 19:27
• Updated: 16/Dec/15 03:49
• Resolved: 16/Dec/15 03:49

Description

The current job group id of a Spark context is stored in the localProperties member value. This data structure is designed to be thread local, and its settings are not preserved when ComplexFutureAction instantiates a new Future.

One consequence of this is that takeAsync() does not behave in the same way as other async actions, e.g. countAsync(). For example, this test (if copied into StatusTrackerSuite.scala), will fail, because "my-job-group2" is not propagated to the Future which actually instantiates the job:

  test("getJobIdsForGroup() with takeAsync()") {
    sc = new SparkContext("local", "test", new SparkConf(false))
    sc.setJobGroup("my-job-group2", "description")
    sc.statusTracker.getJobIdsForGroup("my-job-group2") should be (Seq.empty)
    val firstJobFuture = sc.parallelize(1 to 1000, 1).takeAsync(1)
    val firstJobId = eventually(timeout(10 seconds)) {
      firstJobFuture.jobIds.head
    }
    eventually(timeout(10 seconds)) {
      sc.statusTracker.getJobIdsForGroup("my-job-group2") should be (Seq(firstJobId))
    }
  }

It also impacts current PR for SPARK-1021, which involves additional uses of ComplexFutureAction.

Issue Links

• blocks: SPARK-1021 sortByKey() launches a cluster job when it shouldn't
• links to: [Github] Pull Request #9264 (reggert)