Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-4123

Show dependency changes in pull requests

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Project Infra
    • Labels:
      None

      Description

      We should inspect the classpath of Spark's assembly jar for every pull request. This only takes a few seconds in Maven and it will help weed out dependency changes from the master branch. Ideally we'd post any dependency changes in the pull request message.

      $ mvn -Phive -Phadoop-2.4 dependency:build-classpath -pl assembly  | grep -v INFO | tr : "\n" | awk -F/ '{print $NF}' | sort > my-classpath
      $ git checkout apache/master
      $ mvn -Phive -Phadoop-2.4 dependency:build-classpath -pl assembly  | grep -v INFO | tr : "\n" | awk -F/ '{print $NF}' | sort > master-classpath
      $ diff my-classpath master-classpath
      < chill-java-0.3.6.jar
      < chill_2.10-0.3.6.jar
      ---
      > chill-java-0.5.0.jar
      > chill_2.10-0.5.0.jar
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                boyork Brennon York
                Reporter:
                pwendell Patrick Wendell
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: