[SPARK-4097] Race condition in org.apache.spark.ComplexFutureAction.cancel

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.1.1, 1.2.0
• Component/s: Spark Core
• Labels: bug race-condition
• Assignee: Shixiong Zhu
• Reporter: Shixiong Zhu
• Created: 27/Oct/14 08:22
• Updated: 29/Oct/14 21:44
• Resolved: 29/Oct/14 21:44

Description

There is a chance that `thread` is null when calling `thread.interrupt()`.

  override def cancel(): Unit = this.synchronized {
    _cancelled = true
    if (thread != null) {
      thread.interrupt()
    }
  }

Should put `thread = null` into a `synchronized` block to fix the race condition.

      try {
        p.success(func)
      } catch {
        case e: Exception => p.failure(e)
      } finally {
        thread = null
      }

Issue Links

• links to: [Github] Pull Request #2957 (zsxwing)