[SPARK-40919] Bad case of `AnalysisTest#assertAnalysisErrorClass` when `expectedMessageParameters.size between [2, 4]`

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: Tests
• Assignee: Yang Jie
• Reporter: Yang Jie
• Created: 26/Oct/22 11:50
• Updated: 27/Oct/22 05:01
• Resolved: 27/Oct/22 05:01

Description

If the size of the input parameter `expectedMessageParameters` of the `AnalysisTest#assertAnalysisErrorClass` method is between 2 and 4, the result of `

e.messageParameters.sameElements(expectedMessageParameters)` is related to order.

For example

 

bin/scala
Welcome to Scala 2.12.16 (OpenJDK 64-Bit Server VM, Java 1.8.0_352).
Type in expressions for evaluation. Or try :help.


scala> :paste
// Entering paste mode (ctrl-D to finish)


val messageParameters = Map(
      "exprName" -> "`window_duration`",
      "valueRange" -> s"(0, 9223372036854775807]",
      "currentValue" -> "-1000000L",
      "sqlExpr" -> "\"window(2016-01-01 01:01:01, -1000000, 1000000, 0)\""
    )
val expectedMessageParameters =  Map(
      "sqlExpr" -> "\"window(2016-01-01 01:01:01, -1000000, 1000000, 0)\"",
      "exprName" -> "`window_duration`",
      "valueRange" -> s"(0, 9223372036854775807]",
      "currentValue" -> "-1000000L"
    )


val ret = messageParameters.sameElements(expectedMessageParameters)


// Exiting paste mode, now interpreting.


messageParameters: scala.collection.immutable.Map[String,String] = Map(exprName -> `window_duration`, valueRange -> (0, 9223372036854775807], currentValue -> -1000000L, sqlExpr -> "window(2016-01-01 01:01:01, -1000000, 1000000, 0)")
expectedMessageParameters: scala.collection.immutable.Map[String,String] = Map(sqlExpr -> "window(2016-01-01 01:01:01, -1000000, 1000000, 0)", exprName -> `window_duration`, valueRange -> (0, 9223372036854775807], currentValue -> -1000000L)
ret: Boolean = false

 

 

 

Issue Links

• links to: [Github] Pull Request #38396 (LuciferYang)
• links to: [Github] Pull Request #38396 (LuciferYang)