[SPARK-38694] Simplify Java UT code with Junit `assertThrows`

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: Tests
• Assignee: Yang Jie
• Reporter: Yang Jie
• Created: 30/Mar/22 02:48
• Updated: 30/Mar/22 23:35
• Resolved: 30/Mar/22 23:35

Description

There are some code patterns in Java UTs:

 @Test
  public void testAuthReplay() throws Exception {
    try {
      doSomeOperation();
      fail("Should have failed");
    } catch (Exception e) {
      assertTrue(checkException(e));
    }
  }

or 

 

@Test(expected = SomeException.class)
  public void testAuthReplay() throws Exception {
    try {
      doSomeOperation();
      fail("Should have failed");
    } catch (Exception e) {
      assertTrue(checkException(e));
      throw e;
    }
  } 

we can use Junit assertThrows to simplify the similar patterns

 

 

Issue Links

• links to: [Github] Pull Request #36008 (LuciferYang)
• links to: [Github] Pull Request #36008 (LuciferYang)