Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-37390

Buggy method retrival in pyspark.docs.conf.setup

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.1.0, 3.2.0, 3.3.0
    • 3.1.3, 3.2.1, 3.3.0
    • Documentation, PySpark
    • None

    Description

      Currently we have this code

      def setup(app):
          # The app.add_javascript() is deprecated.
          getattr(app, "add_js_file", getattr(app, "add_javascript"))('copybutton.js')
      

      where nested getattr should handle compatibility issues between different Sphinx versions.

      However, getattr(app, "add_javascript")) is missing default and will fail in latest Sphinx version, without ever falling back to getattr(app, "add_js_file")

       

      Attachments

        Activity

          People

            zero323 Maciej Szymkiewicz
            zero323 Maciej Szymkiewicz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: