[SPARK-33313] R/run-tests.sh is not compatible with testthat >= 3.0

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0, 3.1.0
• Fix Version/s: 2.4.8, 3.0.2, 3.1.0
• Component/s: R, Tests
• Assignee: Maciej Szymkiewicz
• Reporter: Maciej Szymkiewicz
• Created: 01/Nov/20 21:07
• Updated: 12/Dec/22 18:10
• Resolved: 01/Nov/20 23:56

Description

Currently we use testthat:::test_package_dir to run full SparkR tests with testthat > 1.0. However, it has been dropped in testthat 3.0 (https://github.com/r-lib/testthat/pull/1054).

Because of that AppVeyor tests fail with

Spark package found in SPARK_HOME: C:\projects\spark\bin\..
Error in get(name, envir = asNamespace(pkg), inherits = FALSE) : 
  object 'test_package_dir' not found
Calls: ::: -> get
Execution halted

It seems like we can use testthat::test_dir which, since testthat 3.0, supports package parameter.

Issue Links

• links to: [Github] Pull Request #30219 (zero323)
• links to: [Github] Pull Request #30219 (zero323)
• links to: [Github] Pull Request #30220 (HyukjinKwon)
• links to: [Github] Pull Request #30220 (HyukjinKwon)