[SPARK-32467] Avoid encoding URL twice on https redirect

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1, 3.1.0
• Component/s: Web UI
• Assignee: Gengliang Wang
• Reporter: Gengliang Wang
• Created: 28/Jul/20 14:31
• Updated: 06/Jul/21 13:16
• Resolved: 01/Aug/20 05:11

Description

Currently, on https redirect, the original URL is encoded as an HTTPS URL. However, the original URL could be encoded already, so that the return result of method
UriInfo.getQueryParameters will contain encoded keys and values. For example, a parameter
order[0][dir] will become order%255B0%255D%255Bcolumn%255D after encoded twice, and the decoded
key in the result of UriInfo.getQueryParameters will be order%5B0%5D%5Bcolumn%5D.

To fix the problem, we try decoding the query parameters before encoding it. This is to make sure we encode the URL exactly once.

Issue Links

• is related to: SPARK-33195 stages/stage UI page fails to load when spark reverse proxy is enabled
• links to: [Github] Pull Request #29271 (gengliangwang)