[SPARK-31530] Spark submit fails if we provide extraJavaOption which contains Xmx as substring

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 2.4.0
• Component/s: Spark Submit
• Labels: 2.4.0 Spark Submit bulk-closed
• Assignee: Unassigned
• Reporter: Mayank
• Created: 23/Apr/20 10:43
• Updated: 12/Dec/22 18:10
• Resolved: 25/May/21 01:45

Description

Spark submit doesn't allow Xmx anywhere in the spark.driver.extraJavaOptions
For eg:

bin\spark-submit --class org.apache.spark.examples.SparkPi --master local[*] --conf "spark.driver.extraJavaOptions=-DmyKey=MyValueContainsXmx" examples\jars\spark-examples_2.11-2.4.4.jar
Error: Not allowed to specify max heap(Xmx) memory settings through java options (was -DmyKey=MyValueContainsXmx). Use the corresponding --driver-memory or spark.driver.memory configuration instead.

https://github.com/apache/spark/blob/v2.4.4/launcher/src/main/java/org/apache/spark/launcher/SparkClassCommandBuilder.java#L102

https://github.com/apache/spark/blob/master/launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java#L302

Can we update the above condition to check more specific for eg -Xmx