[SPARK-31003] Fix incorrect use of assume() in tests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 2.4.6, 3.0.0
• Component/s: Tests
• Assignee: Josh Rosen
• Reporter: Josh Rosen
• Created: 02/Mar/20 02:46
• Updated: 03/Mar/20 04:21
• Resolved: 02/Mar/20 23:24

Description

Ahir Reddy and I found some cases where assume and assert were mixed up in test suites.

If an assume call fails then it will cause the test to be marked as skipped instead of failed: this is often used to skip tests if certain prerequisites are missing (e.g. to disable certain tests on Windows). If assume is mistakenly used in place of assert then this can cause logically-failing tests to be skipped, masking bugs.

This patch fixes several such cases, replacing certain assume calls with assert. 

Issue Links

• links to: GitHub Pull Request #27754