Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-31003

Fix incorrect use of assume() in tests

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.4.6, 3.0.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Ahir Reddy and I found some cases where assume and assert were mixed up in test suites.

      If an assume call fails then it will cause the test to be marked as skipped instead of failed: this is often used to skip tests if certain prerequisites are missing (e.g. to disable certain tests on Windows). If assume is mistakenly used in place of assert then this can cause logically-failing tests to be skipped, masking bugs.

      This patch fixes several such cases, replacing certain assume calls with assert

        Attachments

          Activity

            People

            • Assignee:
              joshrosen Josh Rosen
              Reporter:
              joshrosen Josh Rosen

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment