[SPARK-30106] DynamicPartitionPruningSuite#"no predicate on the dimension table" is not be tested

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Tests
• Assignee: Deshan Xiao
• Reporter: Deshan Xiao
• Created: 03/Dec/19 07:56
• Updated: 04/Dec/19 07:45
• Resolved: 03/Dec/19 22:28

Description

The test "no predicate on the dimension table is not be tested" has no partiton key. We can change the sql to test it.

      Given("no predicate on the dimension table")
      withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true") {
        val df = sql(
          """
            |SELECT * FROM fact_sk f
            |JOIN dim_store s
            |ON f.date_id = s.store_id
          """.stripMargin)

        checkPartitionPruningPredicate(df, false, false)
      }

Issue Links

• links to: GitHub Pull Request #26744