Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-29310

TestMemoryManager should implement getExecutionMemoryUsageForTask()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0
    • Tests
    • None

    Description

      Spark uses a TestMemoryManager class to mock out memory manager functionality in tests, allowing test authors to exercise control over certain behaviors (e.g. to simulate OOMs).

      Our tests have memory-leak detection to ensure that all allocated memory is cleaned up at the end of each test case; this helps to guard against bugs that could cause production memory leaks.

      Unfortunately, however, this leak-detection logic is broken for tests which use TestMemoryManager because it does not override the getExecutionMemoryUsageForTask() method which the leak-detection mechanism needs.

      Attachments

        Issue Links

          Activity

            People

              joshrosen Josh Rosen
              joshrosen Josh Rosen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: