Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-29310

TestMemoryManager should implement getExecutionMemoryUsageForTask()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Spark uses a TestMemoryManager class to mock out memory manager functionality in tests, allowing test authors to exercise control over certain behaviors (e.g. to simulate OOMs).

      Our tests have memory-leak detection to ensure that all allocated memory is cleaned up at the end of each test case; this helps to guard against bugs that could cause production memory leaks.

      Unfortunately, however, this leak-detection logic is broken for tests which use TestMemoryManager because it does not override the getExecutionMemoryUsageForTask() method which the leak-detection mechanism needs.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                joshrosen Josh Rosen
                Reporter:
                joshrosen Josh Rosen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: