Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-28616

Improve merge-spark-pr script to warn WIP PRs and strip trailing dots

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Project Infra
    • Labels:
      None

      Description

      This issue aims to improve the `merge-spark-pr` script.

      • `[WIP]` is useful when we show that a PR is not ready for merge. Apache Spark allows merging `WIP` PRs. However, sometime, we accidentally forgot to clean up the title for the completed PRs. We had better warn once more during merging stage and get a confirmation from the committers.
      • We have two kinds of PR title in terms of the ending period. This issue aims to remove the trailing `dot` since the shorter is the better in the PR title. Also, the PR titles without the trailing `dot` is dominant in the commit logs.
        $ git log --oneline | grep '[.]$' | wc -l
            4090
        $ git log --oneline | grep '[^.]$' | wc -l
           20747
        

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dongjoon Dongjoon Hyun
                Reporter:
                dongjoon Dongjoon Hyun
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: