Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-28525

Allow Launcher to be applied Java options

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.0
    • Component/s: Deploy
    • Labels:
      None
    • Target Version/s:

      Description

      Launcher is implemented as a Java application and sometimes I'd like to apply Java options.
      One situation I have met is the time I try to attach debugger to Launcher.

      Launcher is launched from bin/spark-class but there is no room to apply Java options.

      build_command() {
        "$RUNNER" -Xmx128m -cp "$LAUNCH_CLASSPATH" org.apache.spark.launcher.Main "$@"
        printf "%d\0" $?
      }
      

      Considering that it's not so many times to apply Java options to Launcher, one compromise would just modify spark-class by user like as follows.

      build_command() {
        "$RUNNER" -Xmx128m $SPARK_LAUNCHER_OPTS -cp "$LAUNCH_CLASSPATH" org.apache.spark.launcher.Main "$@"
        printf "%d\0" $?
      }
      

      But it doesn't work when any text related to Java options is output to standard output because whole output is used as command-string for spark-shell and spark-submit in current implementation.

      One example is jdwp. When apply agentlib option to use jdwp for debug, we will get output like as follows.

      Listening for transport dt_socket at address: 9876
      

      The output shown above is not a command-string so spark-submit and spark-shell will fail.

      To enable Java options for Launcher, we need treat command-string and others.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sarutak Kousuke Saruta
                Reporter:
                sarutak Kousuke Saruta
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: