Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-28496

Use branch name instead of tag during dry-run

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.0.0
    • 2.4.4, 3.0.0
    • Project Infra
    • None

    Description

      There are two cases when we use `dry run`.
      First, when the tag already exists, we can ask `confirmation` on the existing tag name.

      $ dev/create-release/do-release-docker.sh -d /tmp/spark-2.4.4 -n -s docs
      Output directory already exists. Overwrite and continue? [y/n] y
      Branch [branch-2.4]:
      Current branch version is 2.4.4-SNAPSHOT.
      Release [2.4.4]: 2.4.3
      RC # [1]:
      v2.4.3-rc1 already exists. Continue anyway [y/n]? y
      This is a dry run. Please confirm the ref that will be built for testing.
      Ref [v2.4.3-rc1]:
      

      Second, when the tag doesn't exist, we had better ask `confirmation` on the branch name.

      $ dev/create-release/do-release-docker.sh -d /tmp/spark-2.4.4 -n -s docs
      Branch [branch-2.4]:
      Current branch version is 2.4.4-SNAPSHOT.
      Release [2.4.4]:
      RC # [1]:
      This is a dry run. Please confirm the ref that will be built for testing.
      Ref [v2.4.4-rc1]:
      

      Attachments

        Issue Links

          Activity

            People

              dongjoon Dongjoon Hyun
              dongjoon Dongjoon Hyun
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: