[SPARK-28370] Upgrade Mockito to 2.28.2

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Build, Tests
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 12/Jul/19 16:27
• Updated: 29/Nov/19 07:47
• Resolved: 13/Jul/19 20:00

Description

This issue aims to upgrade Mockito from *2.23.4* to *2.28.2* in order to bring the latest bug fixes and to be up-to-date for JDK9+ support before Apache Spark 3.0.0. There is Mockito 3.0 released 4 days ago, but we had better wait and see for the stability.

*RELEASE NOTE*
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md

*NOTABLE FIXES*

• Configure the MethodVisitor for Java 11+ compatibility (2.27.5)
• When mock is called multiple times, and verify fails, the error message reports only the first invocation (2.27.4)
• Memory leak in mockito-inline calling method on mock with at least a mock as parameter (2.25.0)
• Cross-references and a single spy cause memory leak (2.25.0)
• Nested spies cause memory leaks (2.25.0)
• [Java 9 support] ClassCastExceptions with JDK9 javac (2.24.9, 2.24.3)
• Return null instead of causing a CCE (2.24.9, 2.24.3)
• Issue with mocking type in "java.util.*", Java 12 (2.24.2)

Issue Links

• is related to: SPARK-30076 Upgrade Mockito to 3.1.0
• relates to: SPARK-26536 Upgrade Mockito to 2.23.4
• links to: GitHub Pull Request #25139