Minor Description
When running a custom build of Spark which shades commons-codec, the sha1Hex expression generates code which doesn't compile:
org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 47, Column 93: A method named "sha1Hex" is not declared in any enclosing class nor any supertype, nor through a static import
This is caused by an interaction between Spark's code generator and the shading: the current code generator embeds "org.apache.commons.codec.digest.DigestUtils.sha1Hex" into a larger codegen template, preventing JarJarLinks from being able to replace it with the shaded class's name. The generated code ends up using the unshaded name but the unshaded dependency isn't on our classpath, triggering the above compilation error.
To fix this problem and allow for proper shading, we can replace the hardcoded string literal with classof[DigestUtils].getName
Attachments
Issue Links
- links to