[SPARK-26817] Use System.nanoTime to measure time intervals

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 3.0.0
• Component/s: Spark Core
• Assignee: Max Gekk
• Reporter: Max Gekk
• Created: 02/Feb/19 14:16
• Updated: 13/Feb/19 19:15
• Resolved: 13/Feb/19 19:12

Description

Replace System.currentTimeMillis() by System.nanoTime in time intervals measurements. System.currentTimeMillis() returns current wallclock time and will follow changes to the system clock. Thus, negative wallclock adjustments can cause timeouts to "hang" for a long time (until wallclock time has caught up to its previous value again). This can happen when ntpd does a "step" after the network has been disconnected for some time. The most canonical example is during system bootup when DHCP takes longer than usual. This can lead to failures that are really hard to understand/reproduce. System.nanoTime() is guaranteed to be monotonically increasing irrespective of wallclock changes.

 

https://github.com/databricks/scala-style-guide#prefer-nanotime-over-currenttimemillis

Issue Links

• links to: GitHub Pull Request #23727