Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-26564

Fix wrong assertions and error messages for parameter checking

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.0, 2.3.1, 2.3.2, 2.4.0
    • Fix Version/s: 3.0.0
    • Component/s: MLlib, Spark Core, SQL
    • Labels:

      Description

      I mistakenly set an equivalent value with spark.network.timeout to spark.executor.heartbeatInterval and got the following error:

      java.lang.IllegalArgumentException: requirement failed: The value of spark.network.timeout=120s must be no less than the value of spark.executor.heartbeatInterval=120s.
      

      But it can be read as they could be equal. "Greater than" is more precise than "no less than".


      In addition, the following assertions are inconsistent with their messages.

      mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala
       91   require(maxIter >= 0, s"maxIter must be a positive integer: $maxIter")
      
      sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
      416       require(capacity < 512000000, "Cannot broadcast more than 512 millions rows")
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sekikn Kengo Seki
                Reporter:
                sekikn Kengo Seki
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: