Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-25930

Fix scala version string detection when maven-help-plugin is not pre-installed

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0, 3.0.0
    • Fix Version/s: 2.4.1, 3.0.0
    • Component/s: Kubernetes
    • Labels:
      None

      Description

      This line https://github.com/apache/spark/blob/c71db43e11fb90d6675421604ad29f596f2b8bfe/resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh#L32 detects the scala version based on the line that does not contain character `[`

      All lines contain text in brackets besides the scala version:

      [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

      [INFO]
      2.11
      [INFO] ------------------------------------------------------------------------
      [INFO] Reactor Summary:
      [INFO]
      [INFO] Spark Project Parent POM 3.0.0-SNAPSHOT ............ SUCCESS [ 0.446 s]
      [INFO] Spark Project Tags ................................. SKIPPED
      [INFO] Spark Project Sketch ............................... SKIPPED

      If the plugin is not installed several lines will be added to the output :

      [INFO] — maven-help-plugin:2.1.1:evaluate (default-cli) @ spark-parent_2.11 —
      Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugin-tools/maven-plugin-tools-api/2.4.3/maven-plugin-tools-api-2.4.3.pom

      This will mess with the logic above and the scala version will be wrong failing the tests. 

      We should only pick the last line. Although tests are run now manually, this should be fixed.

        Attachments

          Activity

            People

            • Assignee:
              skonto Stavros Kontopoulos
              Reporter:
              skonto Stavros Kontopoulos
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: