[SPARK-25840] `make-distribution.sh` should not fail due to missing LICENSE-binary

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: Build
• Assignee: Dongjoon Hyun
• Reporter: Dongjoon Hyun
• Created: 25/Oct/18 21:06
• Updated: 26/Oct/18 03:27
• Resolved: 26/Oct/18 03:26

Description

We vote for the artifacts. All releases are in the form of the source materials needed to make changes to the software being released.

http://www.apache.org/legal/release-policy.html#artifacts

From Spark 2.4.0, the source artifact and binary artifact starts to contain own proper LICENSE files (LICENSE, LICENSE-binary). It's great to have them. However, unfortunately, `dev/make-distribution.sh` inside source artifacts start to fail because it expects `LICENSE-binary` and source artifact have only the LICENSE file.

https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc4-bin/spark-2.4.0.tgz

dev/make-distribution.sh is used during the voting phase because we are voting on that source artifact instead of GitHub repository. Individual contributors usually don't have the downstream repository and starts to try build the voting source artifacts to help the verification for the source artifact during voting phase. (Personally, I did before.)

This issue aims to recover that script to work in any way. This doesn't aim for source artifacts to reproduce the compiled artifacts.

Issue Links

• links to: [Github] Pull Request #22840 (dongjoon-hyun)