Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-25745

docker-image-tool.sh ignores errors from Docker

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0, 2.3.1, 2.3.2
    • Fix Version/s: 3.0.0
    • Component/s: Deploy, Kubernetes, Spark Core
    • Labels:
      None
    • Target Version/s:

      Description

      In attempting to use the docker-image-tool.sh scripts to build some custom Dockerfiles I ran into issues with the scripts interaction with Docker. Most notably if the Docker build/push fails the script continues blindly ignoring the errors. This can either result in complete failure to build or lead to subtle bugs where images are built against different base images than expected.

      Additionally while the Dockerfiles assume that Spark is first built locally the scripts fail to validate this which they could easily do by checking the expected JARs location. This can also lead to failed Docker builds which could easily be avoided.

        Attachments

          Activity

            People

            • Assignee:
              rvesse Rob Vesse
              Reporter:
              rvesse Rob Vesse
              Shepherd:
              Yinan Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: