Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-25655

Add Pspark-ganglia-lgpl to the scala style check

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0
    • Build
    • None

    Description

      Our lint failed due to the following errors:

      [INFO] --- scalastyle-maven-plugin:1.0.0:check (default) @ spark-ganglia-lgpl_2.11 ---
      error file=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala message=
            Are you sure that you want to use toUpperCase or toLowerCase without the root locale? In most cases, you
            should use toUpperCase(Locale.ROOT) or toLowerCase(Locale.ROOT) instead.
            If you must use toUpperCase or toLowerCase without the root locale, wrap the code block with
            // scalastyle:off caselocale
            .toUpperCase
            .toLowerCase
            // scalastyle:on caselocale
           line=67 column=49
      error file=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala message=
            Are you sure that you want to use toUpperCase or toLowerCase without the root locale? In most cases, you
            should use toUpperCase(Locale.ROOT) or toLowerCase(Locale.ROOT) instead.
            If you must use toUpperCase or toLowerCase without the root locale, wrap the code block with
            // scalastyle:off caselocale
            .toUpperCase
            .toLowerCase
            // scalastyle:on caselocale
           line=71 column=32
      Saving to outputFile=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/target/scalastyle-output.xml
      

      See https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/8890/

      Attachments

        Activity

          People

            smilegator Xiao Li
            smilegator Xiao Li
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: