[SPARK-25425] Extra options must overwrite sessions options

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0, 2.3.1, 2.4.0
• Fix Version/s: 2.3.3, 2.4.0
• Component/s: SQL
• Assignee: Max Gekk
• Reporter: Max Gekk
• Created: 13/Sep/18 20:15
• Updated: 26/Sep/18 06:37
• Resolved: 16/Sep/18 00:38

Description

In load() and save() methods of DataSource V2, extra options are overwritten by session options:

• https://github.com/apache/spark/blob/c9cb393dc414ae98093c1541d09fa3c8663ce276/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L244-L245
• https://github.com/apache/spark/blob/c9cb393dc414ae98093c1541d09fa3c8663ce276/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala#L205

but implementation must be opposite - more specific extra options set via .option(...) must overwrite more common session options

Issue Links

• links to: [Github] Pull Request #22489 (MaxGekk)
• links to: PR